'Re: Review Request 115139: Add outputOnly property to PlasmaCore.Dialog'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 115139: Add outputOnly property to PlasmaCore.Dialog
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-01-20 15:00:44
Message-ID: 20140120150044.7096.45927 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115139/
-----------------------------------------------------------

(Updated Jan. 20, 2014, 3 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Martin Klapetek.

Repository: plasma-framework

Description
-------

Add outputOnly property to PlasmaCore.Dialog

The outputOnly property allows to specify that the dialog should not
accept any input. Thus it's an output only window which supports click
through. This is obviously platform specific and so far it is only
implemented for the X11 platform using the shape extension.

The input shape needs to be set once the window is visible and thus
the functionality is bound to the visible changed signal. The code
ensures that the required shape extension version is present and only
fetches it once.

Diffs
-----

  CMakeLists.txt ef64bdc7c666bf00205f91ff8bce4fee1a6f47c6 
  src/declarativeimports/core/CMakeLists.txt 71f2cb351fe8bf45af563dad39a76fe75da4a0f6 
  src/declarativeimports/core/dialog.h f5d00afc66e52d6049d40f5c76a9ba25135d20f7 
  src/declarativeimports/core/dialog.cpp 2c15f30c10b92870c727e05605bc16aec5836d40 

Diff: https://git.reviewboard.kde.org/r/115139/diff/

Testing
-------

Tested using KWin's desktop change OSD which used to be click-through before the switch to QML.

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115139/">https://git.reviewboard.kde.org/r/115139/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Martin Klapetek.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Jan. 20, 2014, 3 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add outputOnly property to PlasmaCore.Dialog

The outputOnly property allows to specify that the dialog should not
accept any input. Thus it&#39;s an output only window which supports click
through. This is obviously platform specific and so far it is only
implemented for the X11 platform using the shape extension.

The input shape needs to be set once the window is visible and thus
the functionality is bound to the visible changed signal. The code
ensures that the required shape extension version is present and only
fetches it once.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested using KWin&#39;s desktop change OSD which used to be \
click-through before the switch to QML.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(ef64bdc7c666bf00205f91ff8bce4fee1a6f47c6)</span></li>

 <li>src/declarativeimports/core/CMakeLists.txt <span style="color: \
grey">(71f2cb351fe8bf45af563dad39a76fe75da4a0f6)</span></li>

 <li>src/declarativeimports/core/dialog.h <span style="color: \
grey">(f5d00afc66e52d6049d40f5c76a9ba25135d20f7)</span></li>

 <li>src/declarativeimports/core/dialog.cpp <span style="color: \
grey">(2c15f30c10b92870c727e05605bc16aec5836d40)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115139/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 