'Re: Review Request 114589: Fix leaks in MouseEventListener'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 114589: Fix leaks in MouseEventListener
From:       "Commit Hook" <null () kde ! org>
Date:       2014-01-03 18:25:06
Message-ID: 20140103182506.11858.40527 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114589/#review46703
-----------------------------------------------------------

This review has been submitted with commit e57f76c0c00c98b7f79dc963bcaa2e0c707f6f68 \
by David Edmundson to branch master.

- Commit Hook

On Dec. 21, 2013, 8:01 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114589/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2013, 8:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> 
> Fix memory issues in MouseEventListener
> 
> Delete KDeclarativeMouseEvent when emitted
> 
> Do not leak KDeclarativeMouseEvent press and hold events when the mouse
> moves.
> 
> Do not create KDeclarativeMouseEvent when the mouse is hovered. It's
> pointless.
> 
> 
> Add documentation for MouseEventListener
> 
> Add a simple manual test for MouseEventListener
> 
> 
> Diffs
> -----
> 
> src/declarativeimports/qtextracomponents/mouseeventlistener.h 7940846 
> src/declarativeimports/qtextracomponents/mouseeventlistener.cpp 8f925dd 
> src/declarativeimports/qtextracomponents/tests/mouseeventlistenertest.qml \
> PRE-CREATION  
> Diff: https://git.reviewboard.kde.org/r/114589/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114589/">https://git.reviewboard.kde.org/r/114589/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit e57f76c0c00c98b7f79dc963bcaa2e0c707f6f68 by David Edmundson to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On December 21st, 2013, 8:01 p.m. UTC, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Dec. 21, 2013, 8:01 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">

Fix memory issues in MouseEventListener

Delete KDeclarativeMouseEvent when emitted

Do not leak KDeclarativeMouseEvent press and hold events when the mouse
moves.

Do not create KDeclarativeMouseEvent when the mouse is hovered. It&#39;s
pointless.

Add documentation for MouseEventListener

Add a simple manual test for MouseEventListener
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/qtextracomponents/mouseeventlistener.h <span \
style="color: grey">(7940846)</span></li>

 <li>src/declarativeimports/qtextracomponents/mouseeventlistener.cpp <span \
style="color: grey">(8f925dd)</span></li>

 <li>src/declarativeimports/qtextracomponents/tests/mouseeventlistenertest.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114589/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 