'Re: Review Request 114271: drawFloatFrame for QtQuick menus'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 114271: drawFloatFrame for QtQuick menus
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-01-03 8:34:21
Message-ID: 20140103083421.11840.42188 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114271/
-----------------------------------------------------------

(Updated Jan. 3, 2014, 8:34 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, David Edmundson and Hugo Pereira Da Costa.

Repository: kde-workspace

Description
-------

drawFrameMenuPrimitive is entered with a null QWidget if a QQuickMenu is rendered. By \
handling this case we get the menu to render with a frame. Unfortunately we cannot \
render the widget background as that really needs a non-null QWidget and we also do \
not yet get shadows.

Diffs
-----

  kstyles/oxygen/oxygenstyle.cpp 1271e07 

Diff: https://git.reviewboard.kde.org/r/114271/diff/

Testing
-------

I'm not sure whether this can affect other areas if QWidget is null.

File Attachments
----------------

QtQuick menu with fix
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/03/32336a9f-5bd7-4f47-974f-3420882f7cc3__qml-menu-fixed.png
 QtQuick menu without fix
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/03/45e57c8b-324d-4d9a-8fc8-52211f2e8f8d__qml-menu-broken.png

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114271/">https://git.reviewboard.kde.org/r/114271/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, David Edmundson and Hugo Pereira Da Costa.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Jan. 3, 2014, 8:34 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">drawFrameMenuPrimitive is entered with a null QWidget if a QQuickMenu is \
rendered. By handling this case we get the menu to render with a frame. Unfortunately \
we cannot render the widget background as that really needs a non-null QWidget and we \
also do not yet get shadows.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;m not sure whether this can affect other areas if QWidget is \
null.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstyles/oxygen/oxygenstyle.cpp <span style="color: grey">(1271e07)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114271/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/03/32336a9f-5bd7-4f47-974f-3420882f7cc3__qml-menu-fixed.png">QtQuick \
menu with fix</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/03/45e57c8b-324d-4d9a-8fc8-52211f2e8f8d__qml-menu-broken.png">QtQuick \
menu without fix</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 