'Re: Review Request 114746: [calculator runner] Replace regexp with explicit character category check'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 114746: [calculator runner] Replace regexp with explicit character category check
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2013-12-31 11:43:54
Message-ID: 20131231114354.1620.26810 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114746/#review46478
-----------------------------------------------------------

Ship it!

Ship It!

- David Edmundson

On Dec. 31, 2013, 3:06 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114746/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2013, 3:06 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 321803
> http://bugs.kde.org/show_bug.cgi?id=321803
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> The current calculator krunner checks for textual input using a simple [a-zA-Z] \
> regexp, which is going to fail for non-latin letters. Instead of increasing regexp \
> complexity, I simply use the QChar category functions to check for letters. 
> Additionally, any input non consisting of at least a single digit requires the \
> leading or trailing '=' sign, to avoid matches on pure symbol input, such as "(!)" \
> or whatever. 
> 
> Diffs
> -----
> 
> plasma/generic/runners/calculator/calculatorrunner.h 3a031e0 
> plasma/generic/runners/calculator/calculatorrunner.cpp 8d00449 
> 
> Diff: https://git.reviewboard.kde.org/r/114746/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114746/">https://git.reviewboard.kde.org/r/114746/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- David Edmundson</p>

<br />
<p>On December 31st, 2013, 3:06 a.m. UTC, Christoph Feck wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Christoph Feck.</div>

<p style="color: grey;"><i>Updated Dec. 31, 2013, 3:06 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=321803">321803</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The current calculator krunner checks for textual input using a simple \
[a-zA-Z] regexp, which is going to fail for non-latin letters. Instead of increasing \
regexp complexity, I simply use the QChar category functions to check for letters.

Additionally, any input non consisting of at least a single digit requires the \
leading or trailing &#39;=&#39; sign, to avoid matches on pure symbol input, such as \
&quot;(!)&quot; or whatever.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/runners/calculator/calculatorrunner.h <span style="color: \
grey">(3a031e0)</span></li>

 <li>plasma/generic/runners/calculator/calculatorrunner.cpp <span style="color: \
grey">(8d00449)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114746/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 