'Re: Review Request 114681: Removed all X-Plasma-DefaultSize declarations'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 114681: Removed all X-Plasma-DefaultSize declarations
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2013-12-27 22:13:49
Message-ID: 20131227221349.12766.35706 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114681/#review46229
-----------------------------------------------------------

This was already done in the master branch.
origin/frameworks is basically dead. Sorry.

- David Edmundson

On Dec. 27, 2013, 12:37 p.m., Benjamin Kaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114681/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 12:37 p.m.)
> 
> 
> Review request for Plasma and Heena Mahour.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Removed all X-Plasma-DefaultSize declarations in the origin/frameworks branch.
> 
> See GCI Task: http://www.google-melange.com/gci/task/view/google/gci2013/5296523470438400
> 
> 
> Diffs
> -----
> 
>   kwin/effects/maximize/package/metadata.desktop b1ee810 
>   plasma/design/plasmoids d44564f 
>   plasma/desktop/applets/kickoff/package/metadata.desktop e219077 
>   plasma/desktop/applets/showActivityManager/package/metadata.desktop afc65bc 
>   plasma/desktop/applets/taskmanager/package/metadata.desktop ec6d167 
>   plasma/desktop/applets/trash/metadata.desktop f55ae1e 
>   plasma/desktop/applets/window-list/metadata.desktop 8ce3542 
>   plasma/desktop/containments/desktop/package/metadata.desktop 6760db9 
>   plasma/desktop/containments/desktop/tests/org.kde.tests.background/metadata.desktop 2a0f095 
>   plasma/desktop/toolboxes/desktoptoolbox/metadata.desktop 2684dc9 
>   plasma/generic/applets/activitybar/package/metadata.desktop b1f2ece 
>   plasma/generic/applets/analog-clock/metadata.desktop 0691f23 
>   plasma/generic/applets/batterymonitor/metadata.desktop 7896bd9 
>   plasma/generic/applets/devicenotifier/package/metadata.desktop c5877ee 
>   plasma/generic/applets/digital_clock/metadata.desktop 6774abe 
>   plasma/generic/applets/icon/package/metadata.desktop f2387e7 
>   plasma/generic/applets/lock_logout/metadata.desktop a26c9b9 
>   plasma/generic/applets/notifications/metadata.desktop ca9a1d1 
> 
> Diff: https://git.reviewboard.kde.org/r/114681/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Kaiser
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114681/">https://git.reviewboard.kde.org/r/114681/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This was already done in \
the master branch. origin/frameworks is basically dead. Sorry.</pre>
 <br />

<p>- David Edmundson</p>

<br />
<p>On December 27th, 2013, 12:37 p.m. UTC, Benjamin Kaiser wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Heena Mahour.</div>
<div>By Benjamin Kaiser.</div>

<p style="color: grey;"><i>Updated Dec. 27, 2013, 12:37 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removed all X-Plasma-DefaultSize declarations in the origin/frameworks \
branch.

See GCI Task: http://www.google-melange.com/gci/task/view/google/gci2013/5296523470438400</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/maximize/package/metadata.desktop <span style="color: \
grey">(b1ee810)</span></li>

 <li>plasma/design/plasmoids <span style="color: grey">(d44564f)</span></li>

 <li>plasma/desktop/applets/kickoff/package/metadata.desktop <span style="color: \
grey">(e219077)</span></li>

 <li>plasma/desktop/applets/showActivityManager/package/metadata.desktop <span \
style="color: grey">(afc65bc)</span></li>

 <li>plasma/desktop/applets/taskmanager/package/metadata.desktop <span style="color: \
grey">(ec6d167)</span></li>

 <li>plasma/desktop/applets/trash/metadata.desktop <span style="color: \
grey">(f55ae1e)</span></li>

 <li>plasma/desktop/applets/window-list/metadata.desktop <span style="color: \
grey">(8ce3542)</span></li>

 <li>plasma/desktop/containments/desktop/package/metadata.desktop <span style="color: \
grey">(6760db9)</span></li>

 <li>plasma/desktop/containments/desktop/tests/org.kde.tests.background/metadata.desktop \
<span style="color: grey">(2a0f095)</span></li>

 <li>plasma/desktop/toolboxes/desktoptoolbox/metadata.desktop <span style="color: \
grey">(2684dc9)</span></li>

 <li>plasma/generic/applets/activitybar/package/metadata.desktop <span style="color: \
grey">(b1f2ece)</span></li>

 <li>plasma/generic/applets/analog-clock/metadata.desktop <span style="color: \
grey">(0691f23)</span></li>

 <li>plasma/generic/applets/batterymonitor/metadata.desktop <span style="color: \
grey">(7896bd9)</span></li>

 <li>plasma/generic/applets/devicenotifier/package/metadata.desktop <span \
style="color: grey">(c5877ee)</span></li>

 <li>plasma/generic/applets/digital_clock/metadata.desktop <span style="color: \
grey">(6774abe)</span></li>

 <li>plasma/generic/applets/icon/package/metadata.desktop <span style="color: \
grey">(f2387e7)</span></li>

 <li>plasma/generic/applets/lock_logout/metadata.desktop <span style="color: \
grey">(a26c9b9)</span></li>

 <li>plasma/generic/applets/notifications/metadata.desktop <span style="color: \
grey">(ca9a1d1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114681/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 