--===============8211658308222989852== Content-Type: multipart/alternative; boundary="===============5613080369425592264==" --===============5613080369425592264== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114634/ ----------------------------------------------------------- (Updated Dec. 24, 2013, 3:59 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Sinny Kumari. Repository: plasma-mediacenter Description ------- Separate methods for switching and set'ing a new playlist aren't really necessary. This patch eliminates the duplication, and also introduces some more cleanup to related methods. Diffs ----- libs/mediacenter/multipleplaylistmodel.cpp 10ccb40 libs/mediacenter/playlistmodel.h 5a4ac8c libs/mediacenter/playlistmodel.cpp cac6154 Diff: https://git.reviewboard.kde.org/r/114634/diff/ Testing ------- Adding/removing playlist, adding/removing media, removing default playlist work fine. Thanks, Shantanu Tushar --===============5613080369425592264== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114634/

This change has been marked as submitted.


Review request for Plasma and Sinny Kumari.
By Shantanu Tushar.

Updated Dec. 24, 2013, 3:59 p.m.

Repository: plasma-mediacenter

Description

Separate methods for switching and set'ing a new playlist aren't really necessary. This patch eliminates the duplication, and also introduces some more cleanup to related methods.

Testing

Adding/removing playlist, adding/removing media, removing default playlist work fine.

Diffs

  • libs/mediacenter/multipleplaylistmodel.cpp (10ccb40)
  • libs/mediacenter/playlistmodel.h (5a4ac8c)
  • libs/mediacenter/playlistmodel.cpp (cac6154)

View Diff

--===============5613080369425592264==-- --===============8211658308222989852== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8211658308222989852==--