[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114634: Make playlist switching code simpler
From: "Sinny Kumari" <ksinny () gmail ! com>
Date: 2013-12-24 10:03:06
Message-ID: 20131224100306.4851.31996 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114634/#review46129
-----------------------------------------------------------
Ship it!
Looks good to me.
- Sinny Kumari
On Dec. 23, 2013, 7:20 p.m., Shantanu Tushar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114634/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2013, 7:20 p.m.)
>
>
> Review request for Plasma and Sinny Kumari.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Separate methods for switching and set'ing a new playlist aren't really necessary. \
> This patch eliminates the duplication, and also introduces some more cleanup to \
> related methods.
>
> Diffs
> -----
>
> libs/mediacenter/multipleplaylistmodel.cpp 10ccb40
> libs/mediacenter/playlistmodel.h 5a4ac8c
> libs/mediacenter/playlistmodel.cpp cac6154
>
> Diff: https://git.reviewboard.kde.org/r/114634/diff/
>
>
> Testing
> -------
>
> Adding/removing playlist, adding/removing media, removing default playlist work \
> fine.
>
> Thanks,
>
> Shantanu Tushar
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114634/">https://git.reviewboard.kde.org/r/114634/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me.</pre> \
<br />
<p>- Sinny Kumari</p>
<br />
<p>On December 23rd, 2013, 7:20 p.m. UTC, Shantanu Tushar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Sinny Kumari.</div>
<div>By Shantanu Tushar.</div>
<p style="color: grey;"><i>Updated Dec. 23, 2013, 7:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Separate methods for switching and set'ing a new playlist aren't \
really necessary. This patch eliminates the duplication, and also introduces some \
more cleanup to related methods.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding/removing playlist, adding/removing media, removing default \
playlist work fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/mediacenter/multipleplaylistmodel.cpp <span style="color: \
grey">(10ccb40)</span></li>
<li>libs/mediacenter/playlistmodel.h <span style="color: grey">(5a4ac8c)</span></li>
<li>libs/mediacenter/playlistmodel.cpp <span style="color: \
grey">(cac6154)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114634/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic