--===============6305669184365202094== Content-Type: multipart/alternative; boundary="===============7822541928802926189==" --===============7822541928802926189== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114589/#review46067 ----------------------------------------------------------- Ship it! Thanks for both the fix and the documentation! - Marco Martin On Dec. 21, 2013, 8:01 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114589/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2013, 8:01 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > > Fix memory issues in MouseEventListener > > Delete KDeclarativeMouseEvent when emitted > > Do not leak KDeclarativeMouseEvent press and hold events when the mouse > moves. > > Do not create KDeclarativeMouseEvent when the mouse is hovered. It's > pointless. > > > Add documentation for MouseEventListener > > Add a simple manual test for MouseEventListener > > > Diffs > ----- > > src/declarativeimports/qtextracomponents/mouseeventlistener.h 7940846 > src/declarativeimports/qtextracomponents/mouseeventlistener.cpp 8f925dd > src/declarativeimports/qtextracomponents/tests/mouseeventlistenertest.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/114589/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > > --===============7822541928802926189== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114589/

Ship it!

Thanks for both the fix and the documentation!

- Marco Martin


On December 21st, 2013, 8:01 p.m. UTC, David Edmundson wrote:

Review request for Plasma.
By David Edmundson.

Updated Dec. 21, 2013, 8:01 p.m.

Repository: plasma-framework

Description 



Fix memory issues in MouseEventListener

Delete KDeclarativeMouseEvent when emitted

Do not leak KDeclarativeMouseEvent press and hold events when the mouse
moves.

Do not create KDeclarativeMouseEvent when the mouse is hovered. It's
pointless.



Add documentation for MouseEventListener

Add a simple manual test for MouseEventListener

Diffs

  • src/declarativeimports/qtextracomponents/mouseeventlistener.h (7940846)
  • src/declarativeimports/qtextracomponents/mouseeventlistener.cpp (8f925dd)
  • src/declarativeimports/qtextracomponents/tests/mouseeventlistenertest.qml (PRE-CREATION)

View Diff
--===============7822541928802926189==-- --===============6305669184365202094== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6305669184365202094==--