[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements
From: "Shantanu Tushar" <shantanu () kde ! org>
Date: 2013-12-13 17:39:24
Message-ID: 20131213173924.30997.8573 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45662
-----------------------------------------------------------
Ship it!
Ship It!
- Shantanu Tushar
On Dec. 13, 2013, 3:05 p.m., Heena Mahour wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114428/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 3:05 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Replaced Text {} by PlasmaComponents.Label {}
>
>
> Diffs
> -----
>
> mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
> mediaelements/mediawelcome/HomeScreenText.qml 35cd20a
>
> Diff: http://git.reviewboard.kde.org/r/114428/diff/
>
>
> Testing
> -------
>
> works fine .
>
>
> Thanks,
>
> Heena Mahour
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114428/">http://git.reviewboard.kde.org/r/114428/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Shantanu Tushar</p>
<br />
<p>On December 13th, 2013, 3:05 p.m. UTC, Heena Mahour wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.</div> <div>By Heena Mahour.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2013, 3:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Replaced Text {} by PlasmaComponents.Label {} </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works fine .</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediawelcome/BackendsListDelegate.qml <span style="color: \
grey">(e76af63)</span></li>
<li>mediaelements/mediawelcome/HomeScreenText.qml <span style="color: \
grey">(35cd20a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114428/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic