[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports k
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2013-12-13 7:40:57
Message-ID: 20131213074057.12010.74825 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114424/#review45626
-----------------------------------------------------------
This looks like the wrong approach to me. The shadow gets installed by the widget \
style, but lancelot does not use a normal Qt style, but a Plasma style. Because of \
that it would need to use the plasma shadow (e.g. "panel shadow"). The idea of having \
the shadow being controlled by the style was to not use a generic shadow for any \
window as before, but to allow windows to use a shadow matching the window content. \
This would fall back to a "generic" approach.
Please also add ivan to the review.
- Martin Gräßlin
On Dec. 13, 2013, 12:27 a.m., Yichao Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114424/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 12:27 a.m.)
>
>
> Review request for Plasma, Aaron J. Seigo and Martin Gräßlin.
>
>
> Bugs: 320995
> http://bugs.kde.org/show_bug.cgi?id=320995
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> The lancelot main window sets the _KDE_NET_WM_SHADOW property to "1" but never set \
> anything valid to it and therefore has no drop shadow. This patch add the shadow \
> when using a qt style that is aware of the KDE shadow hint in the widget's \
> property. I haven't found a documentation for this property but it seems that they \
> are recognized by oxygen and are also copied to qtcurve (and probably bespin, \
> haven't checked). A better solution might be using the plasma shadow although I \
> don't know how to do that without copying the code to install shadows from kdelibs, \
> unless someone adds a new api to apply plasma themed shadows to a window.
>
> Diffs
> -----
>
> applets/lancelot/application/LancelotWindow.cpp c66c565
>
> Diff: http://git.reviewboard.kde.org/r/114424/diff/
>
>
> Testing
> -------
>
> Compiles.
> Have shadow with both oxygen and qtcurve.
>
>
> Thanks,
>
> Yichao Yu
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114424/">http://git.reviewboard.kde.org/r/114424/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks like the \
wrong approach to me. The shadow gets installed by the widget style, but lancelot \
does not use a normal Qt style, but a Plasma style. Because of that it would need to \
use the plasma shadow (e.g. "panel shadow"). The idea of having the shadow \
being controlled by the style was to not use a generic shadow for any window as \
before, but to allow windows to use a shadow matching the window content. This would \
fall back to a "generic" approach.
Please also add ivan to the review.</pre>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On December 13th, 2013, 12:27 a.m. CET, Yichao Yu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Martin Gräßlin.</div>
<div>By Yichao Yu.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2013, 12:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=320995">320995</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The lancelot main window sets the _KDE_NET_WM_SHADOW property to \
"1" but never set anything valid to it and therefore has no drop shadow. \
This patch add the shadow when using a qt style that is aware of the KDE shadow hint \
in the widget's property. I haven't found a documentation for this property \
but it seems that they are recognized by oxygen and are also copied to qtcurve (and \
probably bespin, haven't checked). A better solution might be using the plasma \
shadow although I don't know how to do that without copying the code to install \
shadows from kdelibs, unless someone adds a new api to apply plasma themed shadows to \
a window. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles. Have shadow with both oxygen and qtcurve.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/lancelot/application/LancelotWindow.cpp <span style="color: \
grey">(c66c565)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114424/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic