[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114263: Port share dataengine to KF5
From: "Andrea Scarpino" <scarpino () kde ! org>
Date: 2013-12-03 9:57:00
Message-ID: 20131203095700.28606.94186 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114263/
-----------------------------------------------------------
(Updated Dec. 3, 2013, 10:56 a.m.)
Review request for KDE Frameworks and Plasma.
Changes
-------
Diff updated.
Repository: kde-workspace
Description
-------
= subject
I also re-factored setUrl(QString&) to setUrl(QUrl&).
Diffs (updated)
-----
plasma/generic/dataengines/CMakeLists.txt 3e94325
plasma/generic/dataengines/share/CMakeLists.txt 9c8f779
plasma/generic/dataengines/share/data/CMakeLists.txt PRE-CREATION
plasma/generic/dataengines/share/plugin_share_package.cpp ac81a31
plasma/generic/dataengines/share/share_package.h 00df488
plasma/generic/dataengines/share/share_package.cpp a31c6c5
plasma/generic/dataengines/share/shareengine.h 4cedc86
plasma/generic/dataengines/share/shareengine.cpp 86c308f
plasma/generic/dataengines/share/shareprovider.h d17ddd9
plasma/generic/dataengines/share/shareprovider.cpp fc528f8
plasma/generic/dataengines/share/shareservice.h 9983292
plasma/generic/dataengines/share/shareservice.cpp b789439
Diff: http://git.reviewboard.kde.org/r/114263/diff/
Testing (updated)
-------
Doesn't build. Looks like an issue with the K_EXPORT_PLASMA_PACKAGE macro.
Thanks,
Andrea Scarpino
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114263/">http://git.reviewboard.kde.org/r/114263/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2013, 10:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Diff updated.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">= subject
I also re-factored setUrl(QString&) to setUrl(QUrl&).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Doesn't build. Looks like an issue with the K_EXPORT_PLASMA_PACKAGE \
macro.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/CMakeLists.txt <span style="color: \
grey">(3e94325)</span></li>
<li>plasma/generic/dataengines/share/CMakeLists.txt <span style="color: \
grey">(9c8f779)</span></li>
<li>plasma/generic/dataengines/share/data/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/dataengines/share/plugin_share_package.cpp <span style="color: \
grey">(ac81a31)</span></li>
<li>plasma/generic/dataengines/share/share_package.h <span style="color: \
grey">(00df488)</span></li>
<li>plasma/generic/dataengines/share/share_package.cpp <span style="color: \
grey">(a31c6c5)</span></li>
<li>plasma/generic/dataengines/share/shareengine.h <span style="color: \
grey">(4cedc86)</span></li>
<li>plasma/generic/dataengines/share/shareengine.cpp <span style="color: \
grey">(86c308f)</span></li>
<li>plasma/generic/dataengines/share/shareprovider.h <span style="color: \
grey">(d17ddd9)</span></li>
<li>plasma/generic/dataengines/share/shareprovider.cpp <span style="color: \
grey">(fc528f8)</span></li>
<li>plasma/generic/dataengines/share/shareservice.h <span style="color: \
grey">(9983292)</span></li>
<li>plasma/generic/dataengines/share/shareservice.cpp <span style="color: \
grey">(b789439)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114263/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic