This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112208/ |
On September 2nd, 2013, 10:32 p.m. UTC, Sebastian Kügler wrote:
I've installed the applet, and had a look in more detail. It's coming along really nicely, and already feels a lot better than the QWidget-based kmix. :) Some issues I've found: - Resizing the popup dialog doesn't resize its content, this leads to unfriendly resizing on the one hand, and clipping of the list of channel items on the other - The listview is draggable when it doesn't have to be, use something like interactive: height < contentsHeight in the ListView to prevent that from happening - The vertical view needs definitely more spacing, if we really want to keep it - Some spacing would do the listview good, this leads to better grouping of the channel items - The item name isn't properly anchored and should either determine the minimum width, or be elided - The percentage on the left hand side should not be bold - The slider feels a bit jerky, this is probably the event round-tripping Xetuan mentions, see that part of the thread - The speaker icon feels a bit weird to mute the channel, I think that's because it's used with different semantics for the applet as well: open mixer (the panel icon). Maybe it could be done with a checkbox, and possibly moved to the top-right, so that the layout - The initial values in the config dialog are not set up correctly. Try switching to master channel only, OK, reopen config dialog: it's set to show all channels. Haven't checked if this is also the case for the orientation - Show all mixers -> "Show all Channels" (i.e. does "mixer" make sense here, or is it really a channel, or a "Volume Control"? - "Mixer slider orientation" -> "Orientation" ? Overall, nice work. This is good stuff. =)On November 27th, 2013, 2:58 p.m. UTC, Sebastian Kügler wrote:
Haven't heard about this in a long time, what's the status?On November 27th, 2013, 4:59 p.m. UTC, Diego Casella wrote:
I'm in a quite busy period lately, but I didn't forget this. I'll be back on it in a week or two :)On November 28th, 2013, 11:44 p.m. UTC, Christian Esken wrote:
From the screenshots its starting to look nice. I have a question about how to integrate this. Likely some people will prefer classic tray (e.g. media player control) and others the QML applet (fits KDE better). I would like to see a seamless integration into KMix, so the user is able to choose between classic tray and QML applet, even from within KMix (1). Do you think this is feasible, Diego? Or does anybody else have an opinion about it? -------- (1) I am currently redoing the configuration dialog using KConfigDialog and am dedicating one Tab to Systray/Sound Menu related features, where this would fit nicely: http://kmix5.wordpress.com/2013/11/26/secret-view-in-the-new-configuration-dialog/On November 29th, 2013, 5:24 p.m. UTC, Diego Casella wrote:
I think Aaron or Marco have a way better answer than the one i could provide, it's in the earlier comments of this rr.
Thanks for hinting this out. It's a long history, but now I found the comment "it would be pretty trivial to add a check in the systemtray to see if the kmix applet exists on the system [...]". It sound to me like this is a future (= not yet existing) extension to the systemtray. But once its there it could be transpararent to KMix. But apsects like global shortcuts (Volume ip/down/mute) and chosing the corresponding master control is only in the KMix GUI, so users must be made aware how they can change it (by starting KMix). This is probably not obvious. If the Mixer configuration would be available in systemsettings, it would be much more visible (as I do not know wheter a systemsettings module and a KConfigDialog can easily use common code, I will stick with KConfigDialog).
- Christian
On August 27th, 2013, 8:40 a.m. UTC, Diego Casella wrote:
Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
By Diego Casella.
Updated Aug. 27, 2013, 8:40 a.m.
Repository:
kmix
Description
Testing
Diffs
File Attachments |