--===============5770374719568635375== Content-Type: multipart/alternative; boundary="===============3173876263299450825==" --===============3173876263299450825== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/ ----------------------------------------------------------- (Updated Nov. 28, 2013, 1:46 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description ------- Set geometry to fill each screen correctly DesktopView incorrectly filled the geometry of screen() screen() will be the screen of the parent shell, not the correct screen. As we were already part-using QScreen, shellcorona is ported to use that instead of QDesktopWidget, so we can keep track of which screen is actually removed instead of just assuming it was the last one. Diffs ----- src/shell/desktopview.h b8b9caa src/shell/desktopview.cpp 90a5730 src/shell/shellcorona.h ee5e2bc src/shell/shellcorona.cpp ef6fbe2 Diff: http://git.reviewboard.kde.org/r/114149/diff/ Testing ------- Used two monitors, and I now have a different wallpaper on each \o/ There's a crash on unplugging a monitor, this happens before my patch and appears to be unrelated. Thanks, David Edmundson --===============3173876263299450825== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/

This change has been marked as submitted.

Review request for Plasma.
By David Edmundson.

Updated Nov. 28, 2013, 1:46 p.m.

Repository: plasma-framework

Description 

Set geometry to fill each screen correctly

DesktopView incorrectly filled the geometry of screen()
screen() will be the screen of the parent shell, not the correct
screen.

As we were already part-using QScreen, shellcorona is ported to use that instead
of QDesktopWidget, so we can keep track of which screen is actually removed instead of just assuming it was the last one.

Testing 

Used two monitors, and I now have a different wallpaper on each \o/

There's a crash on unplugging a monitor, this happens before my patch and appears to be unrelated.

Diffs

  • src/shell/desktopview.h (b8b9caa)
  • src/shell/desktopview.cpp (90a5730)
  • src/shell/shellcorona.h (ee5e2bc)
  • src/shell/shellcorona.cpp (ef6fbe2)

View Diff
--===============3173876263299450825==-- --===============5770374719568635375== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5770374719568635375==--