[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114152: [GCI] FixPicturestrip navigation loop
From: "Egor Matirov" <ematirov () gmail ! com>
Date: 2013-11-27 17:22:03
Message-ID: 20131127172203.17900.54383 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114152/
-----------------------------------------------------------
(Updated Nov. 27, 2013, 5:22 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Repository: plasma-mediacenter
Description
-------
Currently, when you have selected first image from picture strip and clicks previous \
image button then nothing happen. Same way, when user reaches to the last image and \
clicks next image button, then nothing happens. This patch fix it. GCI task: \
http://www.google-melange.com/gci/task/view/google/gci2013/5783943471169536
Diffs
-----
mediaelements/imageviewer/PictureStrip.qml 4825f2e
mediaelements/imageviewer/PictureStripDelegate.qml 9202a52
Diff: http://git.reviewboard.kde.org/r/114152/diff/
Testing
-------
Thanks,
Egor Matirov
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114152/">http://git.reviewboard.kde.org/r/114152/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Egor Matirov.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2013, 5:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, when you have selected first image from picture strip and \
clicks previous image button then nothing happen. Same way, when user reaches to the \
last image and clicks next image button, then nothing happens. This patch fix it. GCI \
task: http://www.google-melange.com/gci/task/view/google/gci2013/5783943471169536</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/imageviewer/PictureStrip.qml <span style="color: \
grey">(4825f2e)</span></li>
<li>mediaelements/imageviewer/PictureStripDelegate.qml <span style="color: \
grey">(9202a52)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114152/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic