[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114152: [GCI] FixPicturestrip navigation loop
From: "Shantanu Tushar" <shantanu () kde ! org>
Date: 2013-11-27 15:52:25
Message-ID: 20131127155225.21789.2997 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 27, 2013, 3:25 p.m., Sinny Kumari wrote:
> > Thank you for patch!
> > Please make changes as Sebastian suggested :)
> >
> > Other than that, there is one issue with this patch. This patch works fine in \
> > case of All pictures, Flickr and Picasa backend but it maynot work as expected in \
> > case of Browse Pictures. Consider the case when there are 2 directories and 4 \
> > pictures in current media browser. In Picturestrip, list of directories (with \
> > width and height 0) will be also there along with pictures. Now, when you are \
> > currently viewing first picture and then you click previous image button, then \
> > instead of going to last image it will go to previous item which will be a \
> > directory. So, in imageviewer you won't see blank screen.
> > To solve this case, As you see that all directories come first and then files. \
> > So, what you will have to do is, check if current item is a directory or file. If \
> > it is a directory just ignore them and move to next/previous item.
> > Hint:
> > isExpandable role will tell you that whether current item is a directory or not.
> > You will have to create a property inside listview delegate to access them \
> > outside listview, property in QML is declared as property bool isDirectory: \
> > isExpandable
> > and to access isDirectory property outside listview, use
> > imageList.currentItem.isDirectory
Also, if you are wondering whose stupid idea was to just visually hide the \
directories in the strip rather than filtering them out, it was me and yes I deserve \
to be kicked :P
- Shantanu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114152/#review44583
-----------------------------------------------------------
On Nov. 27, 2013, 3:01 p.m., Egor Matirov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114152/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2013, 3:01 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Currently, when you have selected first image from picture strip and clicks \
> previous image button then nothing happen. Same way, when user reaches to the last \
> image and clicks next image button, then nothing happens. This patch fix it. GCI \
> task: http://www.google-melange.com/gci/task/view/google/gci2013/5783943471169536
>
> Diffs
> -----
>
> mediaelements/imageviewer/PictureStrip.qml 4825f2e
>
> Diff: http://git.reviewboard.kde.org/r/114152/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Egor Matirov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114152/">http://git.reviewboard.kde.org/r/114152/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 27th, 2013, 3:25 p.m. UTC, <b>Sinny \
Kumari</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Thank you for patch! Please make changes as Sebastian suggested :)
Other than that, there is one issue with this patch. This patch works fine in case of \
All pictures, Flickr and Picasa backend but it maynot work as expected in case of \
Browse Pictures. Consider the case when there are 2 directories and 4 pictures in \
current media browser. In Picturestrip, list of directories (with width and height 0) \
will be also there along with pictures. Now, when you are currently viewing first \
picture and then you click previous image button, then instead of going to last image \
it will go to previous item which will be a directory. So, in imageviewer you \
won't see blank screen.
To solve this case, As you see that all directories come first and then files. So, \
what you will have to do is, check if current item is a directory or file. If it is a \
directory just ignore them and move to next/previous item.
Hint:
isExpandable role will tell you that whether current item is a directory or not.
You will have to create a property inside listview delegate to access them outside \
listview, property in QML is declared as property bool isDirectory: isExpandable
and to access isDirectory property outside listview, use
imageList.currentItem.isDirectory</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also, if you are \
wondering whose stupid idea was to just visually hide the directories in the strip \
rather than filtering them out, it was me and yes I deserve to be kicked :P</pre> <br \
/>
<p>- Shantanu</p>
<br />
<p>On November 27th, 2013, 3:01 p.m. UTC, Egor Matirov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Egor Matirov.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2013, 3:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, when you have selected first image from picture strip and \
clicks previous image button then nothing happen. Same way, when user reaches to the \
last image and clicks next image button, then nothing happens. This patch fix it. GCI \
task: http://www.google-melange.com/gci/task/view/google/gci2013/5783943471169536</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/imageviewer/PictureStrip.qml <span style="color: \
grey">(4825f2e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114152/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic