From kde-panel-devel Wed Nov 27 15:29:42 2013 From: "Martin Klapetek" Date: Wed, 27 Nov 2013 15:29:42 +0000 To: kde-panel-devel Subject: Re: Review Request 114150: Remove KLocale bindings Message-Id: <20131127152942.19025.56517 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=138556619605039 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1906503527964378142==" --===============1906503527964378142== Content-Type: multipart/alternative; boundary="===============6193967101821235730==" --===============6193967101821235730== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114150/ ----------------------------------------------------------- (Updated Nov. 27, 2013, 3:29 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description ------- KLocale is now kde4support and we have QLocale QML bindings. This patch removes the KLocale bindings from plasma-framework (they are not used anywhere anyway). If we miss something from KLocale in QLocale, we should upstream it. Diffs ----- examples/applets/localegallery/metadata.desktop 98856cd examples/applets/localegallery/contents/ui/main.qml 67f9dcd examples/applets/CMakeLists.txt 37780fb examples/applets/testcomponents/contents/ui/DialogContent.qml 9fed86d examples/applets/testcomponents/contents/ui/LocaleItem.qml d8d29e1 src/declarativeimports/CMakeLists.txt e5f0880 src/declarativeimports/locale/CMakeLists.txt bd4c195 src/declarativeimports/locale/calendarsystem.h ccb4fc1 src/declarativeimports/locale/calendarsystem.cpp bc89fac src/declarativeimports/locale/locale.cpp 0b8e568 src/declarativeimports/locale/locale_p.h ebcbeb5 src/declarativeimports/locale/localebindingsplugin.h 85b8fe1 src/declarativeimports/locale/localebindingsplugin.cpp 056794e src/declarativeimports/locale/qmldir d02d98b Diff: http://git.reviewboard.kde.org/r/114150/diff/ Testing ------- Thanks, Martin Klapetek --===============6193967101821235730== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114150/

This change has been marked as submitted.


Review request for Plasma.
By Martin Klapetek.

Updated Nov. 27, 2013, 3:29 p.m.

Repository: plasma-framework

Description

KLocale is now kde4support and we have QLocale QML bindings. This patch removes the KLocale bindings from plasma-framework (they are not used anywhere anyway).

If we miss something from KLocale in QLocale, we should upstream it.

Diffs

  • examples/applets/localegallery/metadata.desktop (98856cd)
  • examples/applets/localegallery/contents/ui/main.qml (67f9dcd)
  • examples/applets/CMakeLists.txt (37780fb)
  • examples/applets/testcomponents/contents/ui/DialogContent.qml (9fed86d)
  • examples/applets/testcomponents/contents/ui/LocaleItem.qml (d8d29e1)
  • src/declarativeimports/CMakeLists.txt (e5f0880)
  • src/declarativeimports/locale/CMakeLists.txt (bd4c195)
  • src/declarativeimports/locale/calendarsystem.h (ccb4fc1)
  • src/declarativeimports/locale/calendarsystem.cpp (bc89fac)
  • src/declarativeimports/locale/locale.cpp (0b8e568)
  • src/declarativeimports/locale/locale_p.h (ebcbeb5)
  • src/declarativeimports/locale/localebindingsplugin.h (85b8fe1)
  • src/declarativeimports/locale/localebindingsplugin.cpp (056794e)
  • src/declarativeimports/locale/qmldir (d02d98b)

View Diff

--===============6193967101821235730==-- --===============1906503527964378142== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1906503527964378142==--