'Re: Review Request 114150: Remove KLocale bindings'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 114150: Remove KLocale bindings
From:       "Commit Hook" <null () kde ! org>
Date:       2013-11-27 15:29:38
Message-ID: 20131127152938.19035.82706 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114150/#review44588
-----------------------------------------------------------

This review has been submitted with commit 13d1f5568f3b61a9bf3f6db9e8f93724061c982c \
by Martin Klapetek to branch master.

- Commit Hook

On Nov. 27, 2013, 12:39 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114150/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2013, 12:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> KLocale is now kde4support and we have QLocale QML bindings. This patch removes the \
> KLocale bindings from plasma-framework (they are not used anywhere anyway). 
> If we miss something from KLocale in QLocale, we should upstream it.
> 
> 
> Diffs
> -----
> 
> examples/applets/localegallery/metadata.desktop 98856cd 
> examples/applets/localegallery/contents/ui/main.qml 67f9dcd 
> examples/applets/CMakeLists.txt 37780fb 
> examples/applets/testcomponents/contents/ui/DialogContent.qml 9fed86d 
> examples/applets/testcomponents/contents/ui/LocaleItem.qml d8d29e1 
> src/declarativeimports/CMakeLists.txt e5f0880 
> src/declarativeimports/locale/CMakeLists.txt bd4c195 
> src/declarativeimports/locale/calendarsystem.h ccb4fc1 
> src/declarativeimports/locale/calendarsystem.cpp bc89fac 
> src/declarativeimports/locale/locale.cpp 0b8e568 
> src/declarativeimports/locale/locale_p.h ebcbeb5 
> src/declarativeimports/locale/localebindingsplugin.h 85b8fe1 
> src/declarativeimports/locale/localebindingsplugin.cpp 056794e 
> src/declarativeimports/locale/qmldir d02d98b 
> 
> Diff: http://git.reviewboard.kde.org/r/114150/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114150/">http://git.reviewboard.kde.org/r/114150/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 13d1f5568f3b61a9bf3f6db9e8f93724061c982c by Martin Klapetek to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On November 27th, 2013, 12:39 p.m. UTC, Martin Klapetek wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated Nov. 27, 2013, 12:39 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KLocale is now kde4support and we have QLocale QML bindings. This patch \
removes the KLocale bindings from plasma-framework (they are not used anywhere \
anyway).

If we miss something from KLocale in QLocale, we should upstream it.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>examples/applets/localegallery/metadata.desktop <span style="color: \
grey">(98856cd)</span></li>

 <li>examples/applets/localegallery/contents/ui/main.qml <span style="color: \
grey">(67f9dcd)</span></li>

 <li>examples/applets/CMakeLists.txt <span style="color: grey">(37780fb)</span></li>

 <li>examples/applets/testcomponents/contents/ui/DialogContent.qml <span \
style="color: grey">(9fed86d)</span></li>

 <li>examples/applets/testcomponents/contents/ui/LocaleItem.qml <span style="color: \
grey">(d8d29e1)</span></li>

 <li>src/declarativeimports/CMakeLists.txt <span style="color: \
grey">(e5f0880)</span></li>

 <li>src/declarativeimports/locale/CMakeLists.txt <span style="color: \
grey">(bd4c195)</span></li>

 <li>src/declarativeimports/locale/calendarsystem.h <span style="color: \
grey">(ccb4fc1)</span></li>

 <li>src/declarativeimports/locale/calendarsystem.cpp <span style="color: \
grey">(bc89fac)</span></li>

 <li>src/declarativeimports/locale/locale.cpp <span style="color: \
grey">(0b8e568)</span></li>

 <li>src/declarativeimports/locale/locale_p.h <span style="color: \
grey">(ebcbeb5)</span></li>

 <li>src/declarativeimports/locale/localebindingsplugin.h <span style="color: \
grey">(85b8fe1)</span></li>

 <li>src/declarativeimports/locale/localebindingsplugin.cpp <span style="color: \
grey">(056794e)</span></li>

 <li>src/declarativeimports/locale/qmldir <span style="color: \
grey">(d02d98b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114150/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 