'Re: Review Request 114114: Remove KLocale QML bindings usage from kde-workspace'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 114114: Remove KLocale QML bindings usage from kde-workspace
From:       "Martin Klapetek" <martin.klapetek () gmail ! com>
Date:       2013-11-26 23:41:08
Message-ID: 20131126234108.17168.44658 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114114/
-----------------------------------------------------------

(Updated Nov. 26, 2013, 11:41 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: kde-workspace

Description
-------

They are unused. Furthermore KLocale is part of kde4support and we don't want to \
depend on that.

After all usage is removed (where removed means either removed unused or ported to \
QLocale QML bindings) from plasma-frameworks, I'll drop the bindings themselves.

Diffs
-----

  plasma/desktop/applets/kickoff/package/contents/ui/configGeneral.qml 6f2bf7b 
  plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml 968b26c 
  plasma/generic/applets/batterymonitor/contents/ui/BatteryItem.qml 7057120 
  plasma/generic/applets/batterymonitor/contents/ui/BrightnessItem.qml 841a050 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml ab05d68 
  plasma/generic/applets/batterymonitor/contents/ui/PowerManagementItem.qml e613ec2 
  plasma/generic/applets/notifications/contents/ui/main.qml b22d30b 

Diff: http://git.reviewboard.kde.org/r/114114/diff/

Testing
-------

Thanks,

Martin Klapetek

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114114/">http://git.reviewboard.kde.org/r/114114/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated Nov. 26, 2013, 11:41 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">They are unused. Furthermore KLocale is part of kde4support and we \
don&#39;t want to depend on that.

After all usage is removed (where removed means either removed unused or ported to \
QLocale QML bindings) from plasma-frameworks, I&#39;ll drop the bindings themselves. \
</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/kickoff/package/contents/ui/configGeneral.qml <span \
style="color: grey">(6f2bf7b)</span></li>

 <li>plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml <span \
style="color: grey">(968b26c)</span></li>

 <li>plasma/generic/applets/batterymonitor/contents/ui/BatteryItem.qml <span \
style="color: grey">(7057120)</span></li>

 <li>plasma/generic/applets/batterymonitor/contents/ui/BrightnessItem.qml <span \
style="color: grey">(841a050)</span></li>

 <li>plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml <span \
style="color: grey">(ab05d68)</span></li>

 <li>plasma/generic/applets/batterymonitor/contents/ui/PowerManagementItem.qml <span \
style="color: grey">(e613ec2)</span></li>

 <li>plasma/generic/applets/notifications/contents/ui/main.qml <span style="color: \
grey">(b22d30b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114114/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 