[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114110: Prints time in the lower right corner
From: "Marco Martin" <notmart () gmail ! com>
Date: 2013-11-25 15:19:54
Message-ID: 20131125151954.6343.20737 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114110/#review44424
-----------------------------------------------------------
I'm not really the reviewer for it, but just my 2 cents:
that's pretty much the reason why at the beginning of the project (a lot of years ago \
by now;) we wanted the possibility to have plasmoids around in the media center.
Just hardcoding the time, while seems easy to do, opens a can of worms since being \
12h or 24 h must have to depend from the system settings, then many will want it, \
many will not want it, then someone may want to have the date too.. and that pretty \
much duplicates the clock plasmoid featuers ;)
- Marco Martin
On Nov. 25, 2013, 3:12 p.m., Oskar Jauch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114110/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2013, 3:12 p.m.)
>
>
> Review request for Plasma and Shantanu Tushar.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Shows time in the lower right corner in 12 hours format in the Plasma MediaCenter.
>
>
> Diffs
> -----
>
> mediaelements/mediawelcome/HomeScreenHeader.qml 2127ce7
> mediaelements/mediawelcome/HomeScreenFooter.qml e6173de
>
> Diff: http://git.reviewboard.kde.org/r/114110/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Oskar Jauch
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114110/">http://git.reviewboard.kde.org/r/114110/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not really the \
reviewer for it, but just my 2 cents:
that's pretty much the reason why at the beginning of the project (a lot of years \
ago by now;) we wanted the possibility to have plasmoids around in the media center.
Just hardcoding the time, while seems easy to do, opens a can of worms since being \
12h or 24 h must have to depend from the system settings, then many will want it, \
many will not want it, then someone may want to have the date too.. and that pretty \
much duplicates the clock plasmoid featuers ;)</pre> <br />
<p>- Marco Martin</p>
<br />
<p>On November 25th, 2013, 3:12 p.m. UTC, Oskar Jauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Shantanu Tushar.</div>
<div>By Oskar Jauch.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2013, 3:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Shows time in the lower right corner in 12 hours format in the Plasma \
MediaCenter.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediawelcome/HomeScreenHeader.qml <span style="color: \
grey">(2127ce7)</span></li>
<li>mediaelements/mediawelcome/HomeScreenFooter.qml <span style="color: \
grey">(e6173de)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114110/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic