[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 113369: Port showActivityManager and add it to desktop layout
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2013-11-25 13:26:40
Message-ID: 20131125132640.18047.73709 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 25, 2013, 6:16 p.m., Sebastian Kügler wrote:
> > plasma/qmlpackages/desktop/contents/layout.js, line 6
> > <http://git.reviewboard.kde.org/r/113369/diff/2/?file=219179#file219179line6>
> >
> > Let's wait with this line, we have a bunch of things to sort out wrt activities \
> > currently. Having the applet ported is definitely useful, but I'd avoid adding it \
> > to the default layout just yet.
That's why I opened review... :)
- Bhushan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113369/#review44387
-----------------------------------------------------------
On Nov. 22, 2013, 8:23 p.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113369/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2013, 8:23 p.m.)
>
>
> Review request for Plasma and Sebastian Kügler.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Port showActivitybar widget to Plasma2 and make it part of default layout,
>
> Nothing in code but needs review because it will alter the default layout.
>
>
> Diffs
> -----
>
> plasma/desktop/applets/CMakeLists.txt c91117a
> plasma/desktop/applets/showActivityManager/CMakeLists.txt 7c73001
> plasma/desktop/applets/showActivityManager/package/contents/ui/main.qml d56c9ab
> plasma/qmlpackages/desktop/contents/layout.js e535b98
>
> Diff: http://git.reviewboard.kde.org/r/113369/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bhushan Shah
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113369/">http://git.reviewboard.kde.org/r/113369/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 25th, 2013, 6:16 p.m. IST, \
<b>Sebastian Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113369/diff/2/?file=219179#file219179line6" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/qmlpackages/desktop/contents/layout.js</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">6</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nx">panel</span><span class="p">.</span><span class="nx">addWidget</span><span \
class="p">(</span><span \
class="s2">"org.kde.showActivityManager"</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let's wait with this \
line, we have a bunch of things to sort out wrt activities currently. Having the \
applet ported is definitely useful, but I'd avoid adding it to the default layout \
just yet.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's \
why I opened review... :)</pre> <br />
<p>- Bhushan</p>
<br />
<p>On November 22nd, 2013, 8:23 p.m. IST, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2013, 8:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port showActivitybar widget to Plasma2 and make it part of default \
layout,
Nothing in code but needs review because it will alter the default layout.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/CMakeLists.txt <span style="color: \
grey">(c91117a)</span></li>
<li>plasma/desktop/applets/showActivityManager/CMakeLists.txt <span style="color: \
grey">(7c73001)</span></li>
<li>plasma/desktop/applets/showActivityManager/package/contents/ui/main.qml <span \
style="color: grey">(d56c9ab)</span></li>
<li>plasma/qmlpackages/desktop/contents/layout.js <span style="color: \
grey">(e535b98)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113369/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic