[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114099: Make the calendar applet follow current locale
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2013-11-25 10:48:47
Message-ID: 20131125104847.17338.25327 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114099/#review44376
-----------------------------------------------------------
src/declarativeimports/calendar/calendar.cpp
<http://git.reviewboard.kde.org/r/114099/#comment31740>
Err, ignore.
- Martin Klapetek
On Nov. 25, 2013, 10:46 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114099/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2013, 10:46 a.m.)
>
>
> Review request for Plasma and Mark Gaiser.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> First day of week is now following locale's first day of week.
>
> Patch also adds comments (copied from kdepim-runtime) and renames startDay to \
> firstDayOfWeek to be more clear what it is.
>
> Diffs
> -----
>
> src/declarativeimports/calendar/calendar.h cc15fcd
> src/declarativeimports/calendar/calendar.cpp 91d95ac
> src/declarativeimports/calendar/qml/DaysCalendar.qml f80d1f9
> src/declarativeimports/calendar/qml/MonthView.qml 533253f
>
> Diff: http://git.reviewboard.kde.org/r/114099/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114099/">http://git.reviewboard.kde.org/r/114099/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/114099/diff/1/?file=219580#file219580line110" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/calendar/calendar.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Calendar::setWeeks(int weeks)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">109</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span><span class="p">(</span><span class="n">day</span> <span \
class="o">></span> <span class="mi">7</span> <span class="o">||</span> <span \
class="n">day</span> <span class="o"><</span> <span class="mi">1</span><span \
class="p">)</span> <span class="p">{</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">110</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qDebug</span><span class="p">()</span> <span class="o"><<</span> \
<span class="s">"{{{{{{{{{{{{{{{{{ setting start day to"</span> <span \
class="o"><<</span> <span class="n">day</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Err, \
ignore.</pre> </div>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On November 25th, 2013, 10:46 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Mark Gaiser.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2013, 10:46 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">First day of week is now following locale's first day of week.
Patch also adds comments (copied from kdepim-runtime) and renames startDay to \
firstDayOfWeek to be more clear what it is.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/calendar.h <span style="color: \
grey">(cc15fcd)</span></li>
<li>src/declarativeimports/calendar/calendar.cpp <span style="color: \
grey">(91d95ac)</span></li>
<li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(f80d1f9)</span></li>
<li>src/declarativeimports/calendar/qml/MonthView.qml <span style="color: \
grey">(533253f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114099/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic