'Re: Review Request 113124: MouseEventListener: Don't process event from children multiple times.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 113124: MouseEventListener: Don't process event from children multiple times.
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2013-11-18 10:06:17
Message-ID: 20131118100617.27949.15430 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113124/#review43878
-----------------------------------------------------------

Ship it!

Ship It!

- Sebastian Kügler

On Oct. 6, 2013, 7:36 p.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113124/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2013, 7:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 316546
> http://bugs.kde.org/show_bug.cgi?id=316546
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> MouseEventListener: Don't process event from children multiple times.
> 
> If an event passed through multiple visually-overlapping children of
> MouseEventListener, the event filter was processing the event every time.
> For example, this caused problems for the KMix icon in the tray, which
> would trigger volume changes three times for every mouse wheel event.
> 
> BUG:316546
> 
> 
> Diffs
> -----
> 
> plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp \
> 36530e075dc52348f32032c32457a090b904c3b9  
> Diff: http://git.reviewboard.kde.org/r/113124/diff/
> 
> 
> Testing
> -------
> 
> The KMix problem is gone, each mouse wheel step now changes the volume by the \
> appropriate amount. 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113124/">http://git.reviewboard.kde.org/r/113124/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Sebastian Kügler</p>

<br />
<p>On October 6th, 2013, 7:36 p.m. UTC, Nicolás Alvarez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Nicolás Alvarez.</div>

<p style="color: grey;"><i>Updated Oct. 6, 2013, 7:36 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=316546">316546</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">MouseEventListener: Don&#39;t process event from children multiple \
times.

If an event passed through multiple visually-overlapping children of
MouseEventListener, the event filter was processing the event every time.
For example, this caused problems for the KMix icon in the tray, which
would trigger volume changes three times for every mouse wheel event.

BUG:316546</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The KMix problem is gone, each mouse wheel step now changes the volume \
by the appropriate amount.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp <span \
style="color: grey">(36530e075dc52348f32032c32457a090b904c3b9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113124/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 