'Re: Review Request 113706: Property for PlasmaCore.Dialog to destroy the platform window when Dialog'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 113706: Property for PlasmaCore.Dialog to destroy the platform window when Dialog
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2013-11-07 13:14:14
Message-ID: 20131107131414.2877.54382 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113706/
-----------------------------------------------------------

(Updated Nov. 7, 2013, 2:14 p.m.)

Status
------

This change has been discarded.

Review request for Plasma.

Repository: plasma-framework

Description
-------

When a QQuickWindow gets hidden in KWin, it cannot be shown again for ATM unknown reasons.
This means that a PlasmaCore.Dialog can only be shown and hidden once, afterwards its
broken.

This new property works around the issue. If set to true the destroy() method is invoked
if the dialog gets hidden and the next show is working again.

Diffs
-----

  src/declarativeimports/core/dialog.h d612882 
  src/declarativeimports/core/dialog.cpp 6b0635f 

Diff: http://git.reviewboard.kde.org/r/113706/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113706/">http://git.reviewboard.kde.org/r/113706/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Nov. 7, 2013, 2:14 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When a QQuickWindow gets hidden in KWin, it cannot be shown again for \
ATM unknown reasons. This means that a PlasmaCore.Dialog can only be shown and hidden \
once, afterwards its broken.

This new property works around the issue. If set to true the destroy() method is \
invoked if the dialog gets hidden and the next show is working again.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/core/dialog.h <span style="color: \
grey">(d612882)</span></li>

 <li>src/declarativeimports/core/dialog.cpp <span style="color: \
grey">(6b0635f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113706/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 