'Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.
From:       "Teemu Rytilahti" <tpr () iki ! fi>
Date:       2013-11-07 0:19:38
Message-ID: 20131107001938.12719.17846 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113697/#review43193
-----------------------------------------------------------

I'm not actually sure whether is okay to force focus after any key is being \
released...

- Teemu Rytilahti

On Nov. 6, 2013, 11:41 p.m., Teemu Rytilahti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113697/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 11:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 314720, 316084 and 324821
> http://bugs.kde.org/show_bug.cgi?id=314720
> http://bugs.kde.org/show_bug.cgi?id=316084
> http://bugs.kde.org/show_bug.cgi?id=324821
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> The focus is being stolen from the input field when alt is being pressed in order \
> to make it possible to use keyboard to do unlocking. Unfortunately this causes the \
> focus never to be returned to the input field. 
> This fixes at least 314720, but perhaps other similar bugs such as 324821 too. \
> 324821 is also partially related. 
> 
> Diffs
> -----
> 
> ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
> 66a3bb4  
> Diff: http://git.reviewboard.kde.org/r/113697/diff/
> 
> 
> Testing
> -------
> 
> Tested on recent git installation.
> 
> 
> Thanks,
> 
> Teemu Rytilahti
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113697/">http://git.reviewboard.kde.org/r/113697/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;m not actually \
sure whether is okay to force focus after any key is being released...</pre>  <br />

<p>- Teemu Rytilahti</p>

<br />
<p>On November 6th, 2013, 11:41 p.m. UTC, Teemu Rytilahti wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Teemu Rytilahti.</div>

<p style="color: grey;"><i>Updated Nov. 6, 2013, 11:41 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=314720">314720</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=316084">316084</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=324821">324821</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The focus is being stolen from the input field when alt is being pressed \
in order to make it possible to use keyboard to do unlocking. Unfortunately this \
causes the focus never to be returned to the input field.

This fixes at least 314720, but perhaps other similar bugs such as 324821 too. 324821 \
is also partially related.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on recent git installation.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
<span style="color: grey">(66a3bb4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113697/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 