'Review Request 113535: Fix build with latest ThreadWeaver'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 113535: Fix build with latest ThreadWeaver
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2013-11-01 13:24:10
Message-ID: 20131101132410.7122.64762 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113535/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.

Repository: plasma-framework

Description
-------

With recent API updates in ThreadWeaver, "enqueueRaw()" was obsoleted. According to \
ThreadWeaver maintainers, the correct way to restart threads is to call \
"reschedule()", but I am not sure if my fix is correct, partly because the comment \
seems to be in the wrong place.

Diffs
-----

  src/plasma/runnermanager.cpp ee4851f 

Diff: http://git.reviewboard.kde.org/r/113535/diff/

Testing
-------

Compiles, no further testing.

Thanks,

Christoph Feck

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113535/">http://git.reviewboard.kde.org/r/113535/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Christoph Feck.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With recent API updates in ThreadWeaver, &quot;enqueueRaw()&quot; was \
obsoleted. According to ThreadWeaver maintainers, the correct way to restart threads \
is to call &quot;reschedule()&quot;, but I am not sure if my fix is correct, partly \
because the comment seems to be in the wrong place.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles, no further testing.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plasma/runnermanager.cpp <span style="color: grey">(ee4851f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113535/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 