--===============1075064729818859149== Content-Type: multipart/alternative; boundary="===============6362648516373031897==" --===============6362648516373031897== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113124/#review42747 ----------------------------------------------------------- Bump. Can we have this fixed soonish? Nicolas, can you push? - Kevin Funk On Oct. 6, 2013, 7:36 p.m., Nicolás Alvarez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113124/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2013, 7:36 p.m.) > > > Review request for Plasma. > > > Bugs: 316546 > http://bugs.kde.org/show_bug.cgi?id=316546 > > > Repository: kde-runtime > > > Description > ------- > > MouseEventListener: Don't process event from children multiple times. > > If an event passed through multiple visually-overlapping children of > MouseEventListener, the event filter was processing the event every time. > For example, this caused problems for the KMix icon in the tray, which > would trigger volume changes three times for every mouse wheel event. > > BUG:316546 > > > Diffs > ----- > > plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp 36530e075dc52348f32032c32457a090b904c3b9 > > Diff: http://git.reviewboard.kde.org/r/113124/diff/ > > > Testing > ------- > > The KMix problem is gone, each mouse wheel step now changes the volume by the appropriate amount. > > > Thanks, > > Nicolás Alvarez > > --===============6362648516373031897== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113124/

Bump. Can we have this fixed soonish? Nicolas, can you push?

- Kevin Funk

On October 6th, 2013, 7:36 p.m. UTC, Nicolás Alvarez wrote:

Review request for Plasma.

By Nicolás Alvarez.

Updated Oct. 6, 2013, 7:36 p.m.

Bugs: 316546

Repository: kde-runtime

Description

MouseEventListener: Don't process event from children multiple times.

If an event passed through multiple visually-overlapping children of
MouseEventListener, the event filter was processing the event every time.
For example, this caused problems for the KMix icon in the tray, which
would trigger volume changes three times for every mouse wheel event.

BUG:316546

Testing

The KMix problem is gone, each mouse wheel step now changes the volume by the appropriate amount.

Diffs

plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp (36530e075dc52348f32032c32457a090b904c3b9)

View Diff

--===============6362648516373031897==-- --===============1075064729818859149== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1075064729818859149==--