From kde-panel-devel Wed Oct 30 09:33:50 2013 From: "Christoph Feck" Date: Wed, 30 Oct 2013 09:33:50 +0000 To: kde-panel-devel Subject: Re: Review Request 113504: Fix krunner calculator letter check Message-Id: <20131030093350.15267.23042 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=138312568226091 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4236569517489611534==" --===============4236569517489611534== Content-Type: multipart/alternative; boundary="===============0325795501516631869==" --===============0325795501516631869== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113504/ ----------------------------------------------------------- (Updated Oct. 30, 2013, 9:33 a.m.) Status ------ This change has been marked as submitted. Review request for kde-workspace and Plasma. Bugs: 326059 http://bugs.kde.org/show_bug.cgi?id=326059 Repository: kde-workspace Description ------- The calculator runner now supports the syntax without the '=', so you can simply type in '3+5' and have the result. An additional commit added a letter check, so that it will not try to compute with normal text input, but this broke any calculations with any functions, such as '=6*asin 0.5' etc. This commit removes the letter check in case the user had explicitly typed the '=', restoring 4.10 behavior. If I understand the letter check correctly, it is very hard to support functions in the case the user had omitted the '=' Diffs ----- plasma/generic/runners/calculator/calculatorrunner.cpp 0d52301 Diff: http://git.reviewboard.kde.org/r/113504/diff/ Testing ------- Thanks, Christoph Feck --===============0325795501516631869== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113504/

This change has been marked as submitted.

Review request for kde-workspace and Plasma.

By Christoph Feck.

Updated Oct. 30, 2013, 9:33 a.m.

Bugs: 326059

Repository: kde-workspace

Description

The calculator runner now supports the syntax without the '=', so you can simply type in '3+5' and have the result. An additional commit added a letter check, so that it will not try to compute with normal text input, but this broke any calculations with any functions, such as '=6*asin 0.5' etc.

This commit removes the letter check in case the user had explicitly typed the '=', restoring 4.10 behavior. If I understand the letter check correctly, it is very hard to support functions in the case the user had omitted the '='

Diffs

plasma/generic/runners/calculator/calculatorrunner.cpp (0d52301)

View Diff

--===============0325795501516631869==-- --===============4236569517489611534== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4236569517489611534==--