'Re: Review Request 109340: Use default background colours for the konsolepreviewer'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109340: Use default background colours for the konsolepreviewer
From:       "Commit Hook" <null () kde ! org>
Date:       2013-10-29 10:51:14
Message-ID: 20131029105114.28230.21813 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109340/#review42614
-----------------------------------------------------------

This review has been submitted with commit d3428e6511d321b1fcbe0930eaabf1d57001c8f2 \
by Giorgos Tsiapaliokas to branch master.

- Commit Hook

On March 11, 2013, 1:31 p.m., Tianyu Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109340/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 1:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=316274
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=316274
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> - Deleted lines hard-coding the background of the konsolepreviwer to white.
> 
> 
> Diffs
> -----
> 
> plasmate/konsole/konsolepreviewer.h 543ff77 
> plasmate/konsole/konsolepreviewer.cpp 05d426e 
> 
> Diff: http://git.reviewboard.kde.org/r/109340/diff/
> 
> 
> Testing
> -------
> 
> Tested on Kubuntu 12.10 with KDE 4.10.1
> Tested with both the default and Krita-Dark colour scheme. In both cases, the text \
> in the konsolepreviewer shows up well against its background. 
> 
> Thanks,
> 
> Tianyu Zhu
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109340/">http://git.reviewboard.kde.org/r/109340/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d3428e6511d321b1fcbe0930eaabf1d57001c8f2 by Giorgos \
Tsiapaliokas to branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On March 11th, 2013, 1:31 p.m. UTC, Tianyu Zhu wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Tianyu Zhu.</div>

<p style="color: grey;"><i>Updated March 11, 2013, 1:31 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=316274">https://bugs.kde.org/show_bug.cgi?id=316274</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Deleted lines hard-coding the background of the konsolepreviwer to \
white.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on Kubuntu 12.10 with KDE 4.10.1 Tested with both the default and \
Krita-Dark colour scheme. In both cases, the text in the konsolepreviewer shows up \
well against its background.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasmate/konsole/konsolepreviewer.h <span style="color: \
grey">(543ff77)</span></li>

 <li>plasmate/konsole/konsolepreviewer.cpp <span style="color: \
grey">(05d426e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109340/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 