[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 113471: Fix crash when removing an item while we are adding one
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-10-27 13:10:32
Message-ID: 20131027131032.30244.58654 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113471/#review42444
-----------------------------------------------------------
Ship it!
not pretty, but it works. one small code issue below that should be fixed before \
pushing.
cheers ..
plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml
<http://git.reviewboard.kde.org/r/113471/#comment30810>
missing {}s (even one-liners get them)
- Aaron J. Seigo
On Oct. 27, 2013, 10:36 a.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113471/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2013, 10:36 a.m.)
>
>
> Review request for kde-workspace, Plasma, Àlex Fiestas, and Michael Zanetti.
>
>
> Bugs: 311871
> http://bugs.kde.org/show_bug.cgi?id=311871
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Reading https://bugs.kde.org/show_bug.cgi?id=311871#c41 you can see that it happens \
> that we are doing a #78 0x00007f4eff8c5ffb in QDeclarativeListModel::insert \
> (this=0x1ebbdb0, index=0, valuemap=...) at util/qdeclarativelistmodel.cpp:436 and \
> then we end up reentring and doing #16 0x00007f4eff8c737f in \
> QDeclarativeListModel::remove (this=0x1ebbdb0, index=6) at \
> util/qdeclarativelistmodel.cpp:402
> Some of the stuff that depends on the QDeclarativeListModel doesn't seem to like \
> getting a "remove" while a "insert" is happening and to be honest m in no mood to \
> fix that, so basically I'm protecting against that happening in our QML code. From \
> what i read you have to be extremely unlucky since the timer only triggers each 10 \
> minutes and it has to trigger at the same time a notification is being added, but \
> oh well, the backtrace points to it and two different people in two different \
> systems say it has stopped the crashes so I don't think it hurts to have this in.
>
> Diffs
> -----
>
> plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml \
> bf33eb1 plasma/generic/applets/notifications/contents/ui/Notifications.qml 114ead2 \
>
> Diff: http://git.reviewboard.kde.org/r/113471/diff/
>
>
> Testing
> -------
>
> I can't reproduce it in my desktop but Alex and Michael have been running this \
> patch for weeks and can certainly say that the crashing situation has improved \
> (i.e. no crashes in days with this patch and crashes daily without it).
>
> Thanks,
>
> Albert Astals Cid
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113471/">http://git.reviewboard.kde.org/r/113471/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">not pretty, but it \
works. one small code issue below that should be fixed before pushing.
cheers ..</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113471/diff/1/?file=205982#file205982line47" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">47</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="nx">notificationsModel</span><span class="p">.</span><span \
class="nx">inserting</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">missing {}s \
(even one-liners get them)</pre> </div>
<br />
<p>- Aaron J. Seigo</p>
<br />
<p>On October 27th, 2013, 10:36 a.m. UTC, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace, Plasma, Àlex Fiestas, and Michael \
Zanetti.</div> <div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Oct. 27, 2013, 10:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311871">311871</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Reading https://bugs.kde.org/show_bug.cgi?id=311871#c41 you can see that \
it happens that we are doing a #78 0x00007f4eff8c5ffb in \
QDeclarativeListModel::insert (this=0x1ebbdb0, index=0, valuemap=...) at \
util/qdeclarativelistmodel.cpp:436 and then we end up reentring and doing
#16 0x00007f4eff8c737f in QDeclarativeListModel::remove (this=0x1ebbdb0, index=6) at \
util/qdeclarativelistmodel.cpp:402
Some of the stuff that depends on the QDeclarativeListModel doesn't seem to like \
getting a "remove" while a "insert" is happening and to be honest \
m in no mood to fix that, so basically I'm protecting against that happening in \
our QML code. From what i read you have to be extremely unlucky since the timer only \
triggers each 10 minutes and it has to trigger at the same time a notification is \
being added, but oh well, the backtrace points to it and two different people in two \
different systems say it has stopped the crashes so I don't think it hurts to \
have this in.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I can't reproduce it in my desktop but Alex and Michael have been \
running this patch for weeks and can certainly say that the crashing situation has \
improved (i.e. no crashes in days with this patch and crashes daily without \
it).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml \
<span style="color: grey">(bf33eb1)</span></li>
<li>plasma/generic/applets/notifications/contents/ui/Notifications.qml <span \
style="color: grey">(114ead2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113471/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic