[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 113420: port activitybar applet to Plasma2
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2013-10-27 4:22:01
Message-ID: 20131027042201.27968.52392 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 27, 2013, 2:12 a.m., David Edmundson wrote:
> > Looks good to me.
> >
> > FWIW, when you move files it's best if you make diffs with "git diff \
> > --find-copies-harder" that way reviewboard doesn't show that you deleted and \
> > created a file. Otherwise I end up commenting on things you didn't change. (
Thanks for the tip! :)
- Bhushan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113420/#review42409
-----------------------------------------------------------
On Oct. 24, 2013, 8:39 p.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113420/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2013, 8:39 p.m.)
>
>
> Review request for Plasma and Sebastian Kügler.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> port activitybar applet to plasma2
>
>
> Diffs
> -----
>
> plasma/generic/applets/CMakeLists.txt f03f941
> plasma/generic/applets/activitybar/CMakeLists.txt 297f1a9
> plasma/generic/applets/activitybar/contents/ui/main.qml PRE-CREATION
> plasma/generic/applets/activitybar/metadata.desktop PRE-CREATION
> plasma/generic/applets/activitybar/package/contents/ui/main.qml a6d5026
> plasma/generic/applets/activitybar/package/metadata.desktop b1f2ece
>
> Diff: http://git.reviewboard.kde.org/r/113420/diff/
>
>
> Testing
> -------
>
> I don't have any stuffs that can help me to test if it switch activities in Plasma2 \
> or not. It lists my kde4 activities..
>
> Thanks,
>
> Bhushan Shah
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113420/">http://git.reviewboard.kde.org/r/113420/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 27th, 2013, 2:12 a.m. IST, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looks good to me.
FWIW, when you move files it's best if you make diffs with "git diff \
--find-copies-harder" that way reviewboard doesn't show that you deleted and \
created a file. Otherwise I end up commenting on things you didn't change. \
(</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the tip! \
:)</pre> <br />
<p>- Bhushan</p>
<br />
<p>On October 24th, 2013, 8:39 p.m. IST, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2013, 8:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">port activitybar applet to plasma2</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I don't have any stuffs that can help me to test if it switch \
activities in Plasma2 or not. It lists my kde4 activities..</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/CMakeLists.txt <span style="color: \
grey">(f03f941)</span></li>
<li>plasma/generic/applets/activitybar/CMakeLists.txt <span style="color: \
grey">(297f1a9)</span></li>
<li>plasma/generic/applets/activitybar/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/activitybar/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/activitybar/package/contents/ui/main.qml <span \
style="color: grey">(a6d5026)</span></li>
<li>plasma/generic/applets/activitybar/package/metadata.desktop <span style="color: \
grey">(b1f2ece)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113420/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic