'Re: Review Request 113362: Port Activity dataengine to KF5'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 113362: Port Activity dataengine to KF5
From:       "Bhushan Shah" <bhush94 () gmail ! com>
Date:       2013-10-21 14:13:36
Message-ID: 20131021141336.13277.39974 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113362/
-----------------------------------------------------------

(Updated Oct. 21, 2013, 2:13 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, Ivan Čukić and Sebastian Kügler.

Repository: kde-workspace

Description
-------

Port KActivity DataEngine to KF5

follow ups:

* Activitybar
* Show activity-manager
* Activity manger (In progress, Since Declarative widgets are gone, converting \
wrapper to private import, will be moved to plasma-framework(?))

Commented out setActivityEncrypted() call because not sure if it is gone or will come \
back..

Also this commit can break build on Jenkins(?).. 

I made this adjustments before KActivity cmake thing.

Diffs
-----

  CMakeLists.txt 57263a3 
  plasma/generic/dataengines/CMakeLists.txt 7826422 
  plasma/generic/dataengines/activities/CMakeLists.txt aa3b607 
  plasma/generic/dataengines/activities/activityengine.cpp cf73d85 
  plasma/generic/dataengines/activities/activityjob.cpp 1a463e2 

Diff: http://git.reviewboard.kde.org/r/113362/diff/

Testing
-------

* Compiles
* Links
* Installs
* Loads in plasmaengineexplorer
* Lists activities and status

Thanks,

Bhushan Shah

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113362/">http://git.reviewboard.kde.org/r/113362/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Ivan Čukić and Sebastian Kügler.</div>
<div>By Bhushan Shah.</div>

<p style="color: grey;"><i>Updated Oct. 21, 2013, 2:13 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port KActivity DataEngine to KF5

follow ups:

* Activitybar
* Show activity-manager
* Activity manger (In progress, Since Declarative widgets are gone, converting \
wrapper to private import, will be moved to plasma-framework(?))

Commented out setActivityEncrypted() call because not sure if it is gone or will come \
back..

Also this commit can break build on Jenkins(?).. 

I made this adjustments before KActivity cmake thing.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* Compiles
* Links
* Installs
* Loads in plasmaengineexplorer
* Lists activities and status
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(57263a3)</span></li>

 <li>plasma/generic/dataengines/CMakeLists.txt <span style="color: \
grey">(7826422)</span></li>

 <li>plasma/generic/dataengines/activities/CMakeLists.txt <span style="color: \
grey">(aa3b607)</span></li>

 <li>plasma/generic/dataengines/activities/activityengine.cpp <span style="color: \
grey">(cf73d85)</span></li>

 <li>plasma/generic/dataengines/activities/activityjob.cpp <span style="color: \
grey">(1a463e2)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113362/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 