'Re: Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only sub'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only sub
From:       "Jeremy Whiting" <jpwhiting () kde ! org>
Date:       2013-10-14 19:40:27
Message-ID: 20131014194027.20498.6993 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112129/
-----------------------------------------------------------

(Updated Oct. 14, 2013, 1:40 p.m.)

Status
------

This change has been discarded.

Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian \
Kügler.

Bugs: https://bugs.kde.org/show_bug.cgi?id=149479
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=149479

Repository: kdelibs

Description
-------

This is the other half of the fix for the listed bug.  I made \
Plasma::PackageStructure::metadata look in the only subdirectory of an extracted \
archive if there's only one subdirectory for the metadata.desktop file.

Diffs
-----

  plasma/packagestructure.cpp 71148e1a18227d9ca847cbffe385aaaad9c66c6b 

Diff: http://git.reviewboard.kde.org/r/112129/diff/

Testing
-------

The bug is fixed here with this and my other patch. Any better ideas for getting the \
only subdirectory are welcome, it feels a bit kludgy as is.

Thanks,

Jeremy Whiting

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112129/">http://git.reviewboard.kde.org/r/112129/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and \
Sebastian Kügler.</div> <div>By Jeremy Whiting.</div>

<p style="color: grey;"><i>Updated Oct. 14, 2013, 1:40 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=149479">https://bugs.kde.org/show_bug.cgi?id=149479</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the other half of the fix for the listed bug.  I made \
Plasma::PackageStructure::metadata look in the only subdirectory of an extracted \
archive if there&#39;s only one subdirectory for the metadata.desktop file.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The bug is fixed here with this and my other patch. Any better ideas for \
getting the only subdirectory are welcome, it feels a bit kludgy as is.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/packagestructure.cpp <span style="color: \
grey">(71148e1a18227d9ca847cbffe385aaaad9c66c6b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112129/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 