'Re: Review Request 113193: fix some warnings'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 113193: fix some warnings
From:       "Alexander Richardson" <arichardson.kde () googlemail ! com>
Date:       2013-10-13 13:44:38
Message-ID: 20131013134438.29128.44927 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113193/
-----------------------------------------------------------

(Updated Oct. 13, 2013, 1:44 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-framework

Description
-------

fix some warnings

Diffs
-----

  src/shell/desktopview.cpp 8eda4be9bed60498a603c67a4234a8c669b729c0 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp d7438506c6d120429d24d6680821030398af6101 
  src/declarativeimports/core/dialog.cpp 4f1d9c8d901b6ce5b14963229bf6b28fc57c8463 
  src/declarativeimports/calendar/calendar.h 5d1f3942501e00235e43b0431a42c5b44f45bc5a 

Diff: http://git.reviewboard.kde.org/r/113193/diff/

Testing
-------

warnings are gone

Thanks,

Alexander Richardson

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113193/">http://git.reviewboard.kde.org/r/113193/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Alexander Richardson.</div>

<p style="color: grey;"><i>Updated Oct. 13, 2013, 1:44 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fix some warnings</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">warnings are gone</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/shell/desktopview.cpp <span style="color: \
grey">(8eda4be9bed60498a603c67a4234a8c669b729c0)</span></li>

 <li>src/scriptengines/qml/plasmoid/containmentinterface.cpp <span style="color: \
grey">(d7438506c6d120429d24d6680821030398af6101)</span></li>

 <li>src/declarativeimports/core/dialog.cpp <span style="color: \
grey">(4f1d9c8d901b6ce5b14963229bf6b28fc57c8463)</span></li>

 <li>src/declarativeimports/calendar/calendar.h <span style="color: \
grey">(5d1f3942501e00235e43b0431a42c5b44f45bc5a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113193/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 