[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 113124: MouseEventListener: Don't process event from children multiple times
From: "Eike Hein" <hein () kde ! org>
Date: 2013-10-05 22:08:45
Message-ID: 20131005220845.8155.10519 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113124/#review41288
-----------------------------------------------------------
plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp
<http://git.reviewboard.kde.org/r/113124/#comment30266>
Not sure about the 'return true' - I think MouseEventListener is supposed to \
never accept events itself. Doesn't the dupe check itself suffice?
- Eike Hein
On Oct. 5, 2013, 9:01 p.m., Nicolás Alvarez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113124/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2013, 9:01 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 316546
> http://bugs.kde.org/show_bug.cgi?id=316546
>
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> MouseEventListener: Don't process event from children multiple times.
>
> If an event passed through multiple visually-overlapping children of
> MouseEventListener, the event filter was processing the event every time.
> For example, this caused problems for the KMix icon in the tray, which
> would trigger volume changes three times for every mouse wheel event.
>
> BUG:316546
>
>
> Diffs
> -----
>
> plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp \
> 36530e075dc52348f32032c32457a090b904c3b9
> Diff: http://git.reviewboard.kde.org/r/113124/diff/
>
>
> Testing
> -------
>
> The KMix problem is gone, each mouse wheel step now changes the volume by the \
> appropriate amount.
>
> Thanks,
>
> Nicolás Alvarez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113124/">http://git.reviewboard.kde.org/r/113124/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113124/diff/1/?file=199530#file199530line170" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
MouseEventListener::handlePressAndHold()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">170</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="nb">true</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure \
about the 'return true' - I think MouseEventListener is supposed to never \
accept events itself. Doesn't the dupe check itself suffice?</pre> </div>
<br />
<p>- Eike Hein</p>
<br />
<p>On October 5th, 2013, 9:01 p.m. UTC, Nicolás Alvarez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Nicolás Alvarez.</div>
<p style="color: grey;"><i>Updated Oct. 5, 2013, 9:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=316546">316546</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">MouseEventListener: Don't process event from children multiple \
times.
If an event passed through multiple visually-overlapping children of
MouseEventListener, the event filter was processing the event every time.
For example, this caused problems for the KMix icon in the tray, which
would trigger volume changes three times for every mouse wheel event.
BUG:316546</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The KMix problem is gone, each mouse wheel step now changes the volume \
by the appropriate amount.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp <span \
style="color: grey">(36530e075dc52348f32032c32457a090b904c3b9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113124/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic