[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 113086: KDeclarative cleanup
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2013-10-04 16:26:37
Message-ID: 20131004162637.7467.35732 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/
-----------------------------------------------------------
(Updated Oct. 4, 2013, 4:26 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Plasma.
Repository: kdelibs
Description
-------
Reorganizes the file structure as the KF5 module suggest.
Adopts newer syntaxes for defining dependencies.
Diffs
-----
CMakeLists.txt 3204c11
experimental/CMakeLists.txt e73a8c4
experimental/COPYING 5185fd3
experimental/COPYING.LIB 2d2d780
experimental/CTestConfig.cmake c383ee1
experimental/KDELibsExperimentalNightly.cmake fd53e0c
experimental/kdeclarative/CMakeLists.txt 72ea7a2
experimental/kdeclarative/bindings/backportglobal.h fca8ade
experimental/kdeclarative/bindings/i18n.cpp 75a67aa
experimental/kdeclarative/bindings/i18n_p.h
experimental/kdeclarative/bindings/icon.cpp dbdc8fe
experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889
experimental/kdeclarative/bindings/url.cpp 3031a6f
experimental/kdeclarative/config-kdeclarative.h.cmake 611c678
experimental/kdeclarative/configpropertymap.h c9ef3ae
experimental/kdeclarative/configpropertymap.cpp 373a655
experimental/kdeclarative/kdeclarative.h
experimental/kdeclarative/kdeclarative.cpp 63ae180
experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a
experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225
experimental/kdeclarative/private/kdeclarative_p.h
experimental/kdeclarative/private/kiconprovider.cpp 8506b8b
experimental/kdeclarative/private/kiconprovider_p.h
experimental/kdeclarative/private/rootcontext.cpp
experimental/kdeclarative/private/rootcontext_p.h
experimental/kdeclarative/qmlobject.h
experimental/kdeclarative/qmlobject.cpp ee81b41
experimental/kdeclarative/qmlobject_p.h
experimental/kdeclarative/test/test.cpp 3986b77
experimental/kdeclarative/test/test.qml 060c265
experimental/kdeclarative/test/testobject_p.h
staging/CMakeLists.txt 5c5c80c
staging/kdeclarative/CMakeLists.txt PRE-CREATION
staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION
staging/kdeclarative/src/CMakeLists.txt PRE-CREATION
staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113086/diff/
Testing
-------
Builds.
There's a test that tests things that are not part either of this module or its \
dependencies:
import Qt 4.7
import org.kde.plasma.core 0.1 as PlasmaCore
import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
I'm unsure what to do with those. (can do in a further commit, we're not moving the \
module to its tier yet)
Thanks,
Aleix Pol Gonzalez
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113086/">http://git.reviewboard.kde.org/r/113086/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Oct. 4, 2013, 4:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Reorganizes the file structure as the KF5 module suggest. Adopts newer \
syntaxes for defining dependencies.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds. There's a test that tests things that are not part either of \
this module or its dependencies:
import Qt 4.7
import org.kde.plasma.core 0.1 as PlasmaCore
import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
I'm unsure what to do with those. (can do in a further commit, we're not \
moving the module to its tier yet)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3204c11)</span></li>
<li>experimental/CMakeLists.txt <span style="color: grey">(e73a8c4)</span></li>
<li>experimental/COPYING <span style="color: grey">(5185fd3)</span></li>
<li>experimental/COPYING.LIB <span style="color: grey">(2d2d780)</span></li>
<li>experimental/CTestConfig.cmake <span style="color: grey">(c383ee1)</span></li>
<li>experimental/KDELibsExperimentalNightly.cmake <span style="color: \
grey">(fd53e0c)</span></li>
<li>experimental/kdeclarative/CMakeLists.txt <span style="color: \
grey">(72ea7a2)</span></li>
<li>experimental/kdeclarative/bindings/backportglobal.h <span style="color: \
grey">(fca8ade)</span></li>
<li>experimental/kdeclarative/bindings/i18n.cpp <span style="color: \
grey">(75a67aa)</span></li>
<li>experimental/kdeclarative/bindings/i18n_p.h <span style="color: \
grey">()</span></li>
<li>experimental/kdeclarative/bindings/icon.cpp <span style="color: \
grey">(dbdc8fe)</span></li>
<li>experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp <span \
style="color: grey">(919e889)</span></li>
<li>experimental/kdeclarative/bindings/url.cpp <span style="color: \
grey">(3031a6f)</span></li>
<li>experimental/kdeclarative/config-kdeclarative.h.cmake <span style="color: \
grey">(611c678)</span></li>
<li>experimental/kdeclarative/configpropertymap.h <span style="color: \
grey">(c9ef3ae)</span></li>
<li>experimental/kdeclarative/configpropertymap.cpp <span style="color: \
grey">(373a655)</span></li>
<li>experimental/kdeclarative/kdeclarative.h <span style="color: \
grey">()</span></li>
<li>experimental/kdeclarative/kdeclarative.cpp <span style="color: \
grey">(63ae180)</span></li>
<li>experimental/kdeclarative/kdeclarativeConfig.cmake.in <span style="color: \
grey">(d68008a)</span></li>
<li>experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in <span style="color: \
grey">(eae2225)</span></li>
<li>experimental/kdeclarative/private/kdeclarative_p.h <span style="color: \
grey">()</span></li>
<li>experimental/kdeclarative/private/kiconprovider.cpp <span style="color: \
grey">(8506b8b)</span></li>
<li>experimental/kdeclarative/private/kiconprovider_p.h <span style="color: \
grey">()</span></li>
<li>experimental/kdeclarative/private/rootcontext.cpp <span style="color: \
grey">()</span></li>
<li>experimental/kdeclarative/private/rootcontext_p.h <span style="color: \
grey">()</span></li>
<li>experimental/kdeclarative/qmlobject.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/qmlobject.cpp <span style="color: \
grey">(ee81b41)</span></li>
<li>experimental/kdeclarative/qmlobject_p.h <span style="color: grey">()</span></li>
<li>experimental/kdeclarative/test/test.cpp <span style="color: \
grey">(3986b77)</span></li>
<li>experimental/kdeclarative/test/test.qml <span style="color: \
grey">(060c265)</span></li>
<li>experimental/kdeclarative/test/testobject_p.h <span style="color: \
grey">()</span></li>
<li>staging/CMakeLists.txt <span style="color: grey">(5c5c80c)</span></li>
<li>staging/kdeclarative/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>staging/kdeclarative/KDeclarativeConfig.cmake.in <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>staging/kdeclarative/src/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>staging/kdeclarative/tests/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113086/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic