[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: [PMC] Review of major refactoring around All Music mode
From: Akshay Ratan <akshayratan () gmail ! com>
Date: 2013-09-28 17:33:46
Message-ID: CAKTp-8RkgVZoOH9XNjgVXRHQ0SDa+rh+uTizQ83mjb+u8wB+yA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Shantanu,
Great work! I will test out the branch soon and would let you know if I
find something :)
Cheers,
Akshay
On Sat, Sep 28, 2013 at 5:24 PM, Shantanu Tushar Jha <shaan7in@gmail.com>wrote:
> Hey,
>
> Thanks for testing, really appreciate that. Also, unless somebody has
> any objection, I will merge this to master tomorrow evening IST. Next,
> I'll create bug reports for the minor nitpicks that are there and we
> can pick them up :)
>
> Cheers,
>
> --
> Shantanu Tushar (UTC +0530)
> http://www.shantanutushar.com
>
> On 9/26/13, Sinny Kumari <ksinny@gmail.com> wrote:
> > Hi Shantanu,
> >
> > Thank you so much for putting so much effort on re-factoring fabian's
> > branch. I checked almost all major/minor features which i remember and
> all
> > of them works absolutely fine. There are some UI issues which can be
> fixed
> > later, but functionality wise most of the stuff works fine.
> >
> > If needed you can wait for getting feedback from other community people
> as
> > well. From my side, you can merge into master :)
> >
> > Cheers!
> >
> > On Mon, Sep 23, 2013 at 9:27 PM, Shantanu Tushar Jha
> > <shantanu@kde.org>wrote:
> >
> >> Hi,
> >>
> >> * tl;dr *
> >> There is new refactored code in fabian-refactoring-shantanu which should
> >> be functionally same as master. Please take some time, test it and
> report
> >> if it works fine, or if a major feature is broken.
> >>
> >> * Long version *
> >>
> >> Thanks to Fabian, we had started refactoring Plasma Media Center's media
> >> browsing code so as to create more reusable components. Finally this is
> >> complete with all major functionality working.
> >>
> >> The code for this lies in the branch fabian-refactoring-shantanu . The
> >> salient features are-
> >>
> >> 1. Backends can now expose multiple models instead of just one. The
> media
> >> browser is smart enough to understand how to display these. See #2.
> There
> >> is 100% backwards compatibility in the sense that older backends with
> >> only
> >> one model will continue to work, internally stored as a list of just one
> >> model.
> >>
> >> 2. We now have the following reusable components throughout PMC-
> >> * GridBrowser - as the name says, give it a backend/model and it will
> >> show
> >> items in a grid
> >> * ListBrowser - same as above, but a list
> >> * SplitBrowser - can show two browsers side-by-side for two models
> >> * TabBrowser - takes a backend and list of models and shows a browser
> for
> >> each model in tabs
> >> * SmartBrowser - give it a model or a list of models, and it figures out
> >> which of the above browsers to use
> >>
> >> 3. Due to these changes, method calls like expand, search etc now take a
> >> parameter to the model on which they need to operate. There is 100%
> >> backwards compatibility where if the parameter is not present, the first
> >> model is picked up.
> >>
> >> 4. Search can now operate on individual models, giving you support to
> >> search any model in your backend. See #3
> >>
> >> 5. *Best of all* We can throw all the custom/duplicated code for All
> >> Music
> >> backend as generic browsers in #2 take care of that. (1006 less lines of
> >> code!)
> >>
> >> What do we need? Well if you get some time, please checkout the branch
> >> fabian-refactoring-shantanu , test it to make sure no major features are
> >> broken. Note, there are still few minor keyboard/UI issues which I will
> >> create bug reports for once merged to master.
> >>
> >> What next? I eagerly wait for comments on how the new browsers work, and
> >> unless some major feature is broken, I will go ahead and merge with
> >> master
> >> this weekend, or earlier if people try out and find no issues.
> >>
> >> Thanks!
> >>
> >> --
> >> Shantanu Tushar (UTC +0530)
> >> http://www.shantanutushar.com
> >>
> >> _______________________________________________
> >> Plasma-devel mailing list
> >> Plasma-devel@kde.org
> >> https://mail.kde.org/mailman/listinfo/plasma-devel
> >>
> >>
> >
> >
> > --
> > http://www.sinny.in
> >
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
--
Akshay
[Attachment #5 (text/html)]
<div dir="ltr">Hi Shantanu,<div><br></div><div>Great work! I will test out the branch \
soon and would let you know if I find something \
:)</div><div><br></div><div>Cheers,</div><div>Akshay</div></div><div \
class="gmail_extra"> <br><br><div class="gmail_quote">On Sat, Sep 28, 2013 at 5:24 \
PM, Shantanu Tushar Jha <span dir="ltr"><<a href="mailto:shaan7in@gmail.com" \
target="_blank">shaan7in@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Hey,<br>
<br>
Thanks for testing, really appreciate that. Also, unless somebody has<br>
any objection, I will merge this to master tomorrow evening IST. Next,<br>
I'll create bug reports for the minor nitpicks that are there and we<br>
can pick them up :)<br>
<br>
Cheers,<br>
<div class="im HOEnZb"><br>
--<br>
Shantanu Tushar (UTC +0530)<br>
<a href="http://www.shantanutushar.com" \
target="_blank">http://www.shantanutushar.com</a><br> <br>
</div><div class="HOEnZb"><div class="h5">On 9/26/13, Sinny Kumari <<a \
href="mailto:ksinny@gmail.com">ksinny@gmail.com</a>> wrote:<br> > Hi \
Shantanu,<br> ><br>
> Thank you so much for putting so much effort on re-factoring fabian's<br>
> branch. I checked almost all major/minor features which i remember and all<br>
> of them works absolutely fine. There are some UI issues which can be fixed<br>
> later, but functionality wise most of the stuff works fine.<br>
><br>
> If needed you can wait for getting feedback from other community people as<br>
> well. From my side, you can merge into master :)<br>
><br>
> Cheers!<br>
><br>
> On Mon, Sep 23, 2013 at 9:27 PM, Shantanu Tushar Jha<br>
> <<a href="mailto:shantanu@kde.org">shantanu@kde.org</a>>wrote:<br>
><br>
>> Hi,<br>
>><br>
>> * tl;dr *<br>
>> There is new refactored code in fabian-refactoring-shantanu which should<br>
>> be functionally same as master. Please take some time, test it and \
report<br> >> if it works fine, or if a major feature is broken.<br>
>><br>
>> * Long version *<br>
>><br>
>> Thanks to Fabian, we had started refactoring Plasma Media Center's \
media<br> >> browsing code so as to create more reusable components. Finally \
this is<br> >> complete with all major functionality working.<br>
>><br>
>> The code for this lies in the branch fabian-refactoring-shantanu . The<br>
>> salient features are-<br>
>><br>
>> 1. Backends can now expose multiple models instead of just one. The \
media<br> >> browser is smart enough to understand how to display these. See \
#2. There<br> >> is 100% backwards compatibility in the sense that older \
backends with<br> >> only<br>
>> one model will continue to work, internally stored as a list of just one<br>
>> model.<br>
>><br>
>> 2. We now have the following reusable components throughout PMC-<br>
>> * GridBrowser - as the name says, give it a backend/model and it will<br>
>> show<br>
>> items in a grid<br>
>> * ListBrowser - same as above, but a list<br>
>> * SplitBrowser - can show two browsers side-by-side for two models<br>
>> * TabBrowser - takes a backend and list of models and shows a browser \
for<br> >> each model in tabs<br>
>> * SmartBrowser - give it a model or a list of models, and it figures out<br>
>> which of the above browsers to use<br>
>><br>
>> 3. Due to these changes, method calls like expand, search etc now take a<br>
>> parameter to the model on which they need to operate. There is 100%<br>
>> backwards compatibility where if the parameter is not present, the first<br>
>> model is picked up.<br>
>><br>
>> 4. Search can now operate on individual models, giving you support to<br>
>> search any model in your backend. See #3<br>
>><br>
>> 5. *Best of all* We can throw all the custom/duplicated code for All<br>
>> Music<br>
>> backend as generic browsers in #2 take care of that. (1006 less lines of<br>
>> code!)<br>
>><br>
>> What do we need? Well if you get some time, please checkout the branch<br>
>> fabian-refactoring-shantanu , test it to make sure no major features are<br>
>> broken. Note, there are still few minor keyboard/UI issues which I will<br>
>> create bug reports for once merged to master.<br>
>><br>
>> What next? I eagerly wait for comments on how the new browsers work, and<br>
>> unless some major feature is broken, I will go ahead and merge with<br>
>> master<br>
>> this weekend, or earlier if people try out and find no issues.<br>
>><br>
>> Thanks!<br>
>><br>
>> --<br>
>> Shantanu Tushar (UTC +0530)<br>
>> <a href="http://www.shantanutushar.com" \
target="_blank">http://www.shantanutushar.com</a><br> >><br>
>> _______________________________________________<br>
>> Plasma-devel mailing list<br>
>> <a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
>> <a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
>><br> >><br>
><br>
><br>
> --<br>
> <a href="http://www.sinny.in" target="_blank">http://www.sinny.in</a><br>
><br>
_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Akshay \
</div>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic