From kde-panel-devel Thu Sep 26 00:15:36 2013 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Thu, 26 Sep 2013 00:15:36 +0000 To: kde-panel-devel Subject: Re: Review Request 112727: Shrink (fancy) unhide trigger when entered while FS window is active Message-Id: <20130926001536.17859.96504 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=138015456127656 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5616074323551699023==" --===============5616074323551699023== Content-Type: multipart/alternative; boundary="===============1333051290676889340==" --===============1333051290676889340== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > On Sept. 24, 2013, 10:31 a.m., Martin Gräßlin wrote: > > > no idea whether that's acceptable > > shouldn't be much of an issue. KWindowSystem is emitting a signal, isn't it? activeWindowChanged() There's been concerns about waking up when windows were moved and KWindowSystem has no disconnectNotify implementation, so once you hooked onto KWindowSystem signals, you're afair not easily getting rid of it's X11 event filtering. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112727/#review40664 ----------------------------------------------------------- On Sept. 14, 2013, 2:36 p.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112727/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2013, 2:36 p.m.) > > > Review request for Plasma, Aaron J. Seigo and Martin Gräßlin. > > > Description > ------- > > Drawback: the next trigger will go unfancied (would require listening to active window changes, no idea whether that's acceptable) but that's still much better than occluding 30 outer px of a window (see bug and http://forum.kde.org/viewtopic.php?f=111&t=112163) > > Notice that > a) nor auto unhiding neither hinting happens at all while there's a(n active) fullscreen window - this is unchanged (see early exit in patched branch) > b) the patch does nothing if you don't attempt to enter the occluded area of a fullscreen window (so not even the next hinting will be affected) > > > This addresses bug 217560. > http://bugs.kde.org/show_bug.cgi?id=217560 > > > Diffs > ----- > > plasma/desktop/shell/panelview.cpp dcd051a > > Diff: http://git.reviewboard.kde.org/r/112727/diff/ > > > Testing > ------- > > m_unhideTrigger shrinks and the next unhide is not indicated (but the panel appears), subsequent indication remains unaffected. > > > Thanks, > > Thomas Lübking > > --===============1333051290676889340== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112727/

On September 24th, 2013, 10:31 a.m. UTC, Martin Gräßlin wrote:
> no idea whether that's acceptable
shouldn't be much of an issue. KWindowSystem is emitting a signal, isn't it? activeWindowChanged()

There's been concerns about waking up when windows were moved and KWindowSystem has no disconnectNotify implementation, so once you hooked onto KWindowSystem signals, you're afair not easily getting rid of it's X11 event filtering.

- Thomas

On September 14th, 2013, 2:36 p.m. UTC, Thomas Lübking wrote:

Review request for Plasma, Aaron J. Seigo and Martin Gräßlin.

By Thomas Lübking.

Updated Sept. 14, 2013, 2:36 p.m.

Description

Drawback: the next trigger will go unfancied (would require listening to active window changes, no idea whether that's acceptable) but that's still much better than occluding 30 outer px of a window (see bug and http://forum.kde.org/viewtopic.php?f=111&t=112163)

Notice that
a) nor auto unhiding neither hinting happens at all while there's a(n active) fullscreen window - this is unchanged (see early exit in patched branch)
b) the patch does nothing if you don't attempt to enter the occluded area of a fullscreen window (so not even the next hinting will be affected)

Testing

m_unhideTrigger shrinks and the next unhide is not indicated (but the panel appears), subsequent indication remains unaffected.

Bugs: 217560

Diffs

plasma/desktop/shell/panelview.cpp (dcd051a)

--===============1333051290676889340==-- --===============5616074323551699023== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5616074323551699023==--