[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists
From:       Sebastian =?ISO-8859-1?Q?K=FCgler?= <sebas () kde ! org>
Date:       2013-09-25 9:22:57
Message-ID: 2456261.xsjR13HmQb () miro ! vizzzion ! net
[Download RAW message or body]

CMake-gods, can you confirm the below? (It's inconsistent with my =

understanding, and how we've done it in the past months, I'd like to have a =

specialist opinion before going around and changing every single =

CMakeLists.txt in Plasma.)

Thanks,

-- sebas


----------  Forwarded Message  ----------

Subject: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists
Date: Wednesday, September 25, 2013, 10:36:46
From: Martin Gr=E4=DFlin <mgraesslin@kde.org>
To: plasma-devel@kde.org

Hi all,

just a short reminder. When adjusting a CMakeLists.txt to Qt5 to enable e.g=
. a =

dataengine please use the new namespace syntax in target_link_libraries. E.=
g:

 target_link_libraries(plasma_engine_notifications
     Qt5::DBus
    KF5::KI18n
    KF5::KIconThemes
    KF5::KIOCore
    KF5::KNotifications
    KF5::plasma
    KF5::KService
     ${KDE4_KNOTIFYCONFIG_LIBRARY}
 )

and not

 target_link_libraries(plasma_engine_notifications
     Qt5::DBus
    ${Plasma_LIBRARIES}
    ${KI18n_LIBRARIES}
    ${KIconThemes_LIBRARIES}
    ${KNotifications_LIBRARIES}
    ${KService_LIBRARIES}
    ${KDE4_KIO_LIBS}
     ${KDE4_KNOTIFYCONFIG_LIBRARY}
 )

I just spent the last half our fixing linker errors as  ${KI18n_LIBRARIES} =

didn't exist any more.

Thanks,
Martin
-----------------------------------------
-- =

sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]