This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/

This change has been marked as submitted.


Review request for Plasma, Marco Martin and Sebastian Kügler.
By Bhushan Shah.

Updated Sept. 23, 2013, 3:59 p.m.

Description

Port Icon applet to plasma2

Some issues..

-> Can be resized to 1x1.
-> Still doesn't work for folder, and external URLs.
-> Configuration dialog

Testing

1) Compiles
2) Installs
3) Loads

-> Dropping application icon from KickOff - creates icon
-> Dropping files from Dolphin, both executable and normal files - creates icon
-> Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet.

4) Opens URL - Clicking on the icon applet opens url with kfmclient

Diffs

  • plasma/generic/applets/CMakeLists.txt (4ace449)
  • plasma/generic/applets/icon/CMakeLists.txt (1094666)
  • plasma/generic/applets/icon/package/contents/config/main.xml (PRE-CREATION)
  • plasma/generic/applets/icon/package/contents/ui/main.qml (PRE-CREATION)
  • plasma/generic/applets/icon/package/metadata.desktop (PRE-CREATION)
  • plasma/generic/applets/icon/plugin/icon_p.h (PRE-CREATION)
  • plasma/generic/applets/icon/plugin/icon_p.cpp (PRE-CREATION)
  • plasma/generic/applets/icon/plugin/iconplugin.h (PRE-CREATION)
  • plasma/generic/applets/icon/plugin/iconplugin.cpp (PRE-CREATION)
  • plasma/generic/applets/icon/plugin/qmldir (PRE-CREATION)

View Diff

File Attachments