From kde-panel-devel Mon Sep 23 15:59:01 2013 From: "Commit Hook" Date: Mon, 23 Sep 2013 15:59:01 +0000 To: kde-panel-devel Subject: Re: Review Request 112888: Roughly port icon applet to plasma2 Message-Id: <20130923155901.6635.56067 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=137995196024865 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3846215612281449481==" --===============3846215612281449481== Content-Type: multipart/alternative; boundary="===============8589596860887991232==" --===============8589596860887991232== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ ----------------------------------------------------------- (Updated Sept. 23, 2013, 3:59 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma, Marco Martin and Sebastian Kügler. Description ------- Port Icon applet to plasma2 Some issues.. -> Can be resized to 1x1. -> Still doesn't work for folder, and external URLs. -> Configuration dialog Diffs ----- plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing ------- 1) Compiles 2) Installs 3) Loads -> Dropping application icon from KickOff - creates icon -> Dropping files from Dolphin, both executable and normal files - creates icon -> Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments ---------------- icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah --===============8589596860887991232== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/

This change has been marked as submitted.

Review request for Plasma, Marco Martin and Sebastian Kügler.
By Bhushan Shah.

Updated Sept. 23, 2013, 3:59 p.m.

Description 

Port Icon applet to plasma2

Some issues..

-> Can be resized to 1x1.
-> Still doesn't work for folder, and external URLs.
-> Configuration dialog

Testing 

1) Compiles
2) Installs
3) Loads

-> Dropping application icon from KickOff - creates icon
-> Dropping files from Dolphin, both executable and normal files - creates icon
-> Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet.

4) Opens URL - Clicking on the icon applet opens url with kfmclient

Diffs

  • plasma/generic/applets/CMakeLists.txt (4ace449)
  • plasma/generic/applets/icon/CMakeLists.txt (1094666)
  • plasma/generic/applets/icon/package/contents/config/main.xml (PRE-CREATION)
  • plasma/generic/applets/icon/package/contents/ui/main.qml (PRE-CREATION)
  • plasma/generic/applets/icon/package/metadata.desktop (PRE-CREATION)
  • plasma/generic/applets/icon/plugin/icon_p.h (PRE-CREATION)
  • plasma/generic/applets/icon/plugin/icon_p.cpp (PRE-CREATION)
  • plasma/generic/applets/icon/plugin/iconplugin.h (PRE-CREATION)
  • plasma/generic/applets/icon/plugin/iconplugin.cpp (PRE-CREATION)
  • plasma/generic/applets/icon/plugin/qmldir (PRE-CREATION)

View Diff

File Attachments

--===============8589596860887991232==-- --===============3846215612281449481== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3846215612281449481==--