'Re: Review Request 112727: Shrink (fancy) unhide trigger when entered while FS window is active'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 112727: Shrink (fancy) unhide trigger when entered while FS window is active
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2013-09-14 14:36:49
Message-ID: 20130914143649.29454.23731 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112727/
-----------------------------------------------------------

(Updated Sept. 14, 2013, 2:36 p.m.)

Review request for Plasma, Aaron J. Seigo and Martin Gräßlin.

Description
-------

Drawback: the next trigger will go unfancied (would require listening to active \
window changes, no idea whether that's acceptable) but that's still much better than \
occluding 30 outer px of a window (see bug and \
http://forum.kde.org/viewtopic.php?f=111&t=112163)

Notice that
a) nor auto unhiding neither hinting happens at all while there's a(n active) \
fullscreen window - this is unchanged (see early exit in patched branch) b) the patch \
does nothing if you don't attempt to enter the occluded area of a fullscreen window \
(so not even the next hinting will be affected)

This addresses bug 217560.
    http://bugs.kde.org/show_bug.cgi?id=217560

Diffs
-----

  plasma/desktop/shell/panelview.cpp dcd051a 

Diff: http://git.reviewboard.kde.org/r/112727/diff/

Testing
-------

m_unhideTrigger shrinks and the next unhide is not indicated (but the panel appears), \
subsequent indication remains unaffected.

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112727/">http://git.reviewboard.kde.org/r/112727/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Aaron J. Seigo and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Sept. 14, 2013, 2:36 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Drawback: the next trigger will go unfancied (would require listening to \
active window changes, no idea whether that&#39;s acceptable) but that&#39;s still \
much better than occluding 30 outer px of a window (see bug and \
http://forum.kde.org/viewtopic.php?f=111&amp;t=112163)

Notice that
a) nor auto unhiding neither hinting happens at all while there&#39;s a(n active) \
fullscreen window - this is unchanged (see early exit in patched branch) b) the patch \
does nothing if you don&#39;t attempt to enter the occluded area of a fullscreen \
window (so not even the next hinting will be affected)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">m_unhideTrigger shrinks and the next unhide is not indicated (but the \
panel appears), subsequent indication remains unaffected.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=217560">217560</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/shell/panelview.cpp <span style="color: \
grey">(dcd051a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112727/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 