[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Activities API
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2013-09-12 23:34:23
Message-ID: 1420453.ORTkA9rUKu () freedom
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday, September 12, 2013 16:19:18 Martin Graesslin wrote:
> On Thursday 12 September 2013 15:51:55 Aaron J. Seigo wrote:
> > On Thursday, September 12, 2013 15:26:50 Marco Martin wrote:
> > > in general to c++ it's maybe slightly clunkier, since one has to call
> > > model->
> > > 
> > > >data(role) and then try to convert the qvariant.
> > > 
> > > (perhaps it may have some api to ease fetch data from c++)
> > > 
> > > on QML... would be awesome :D
> > 
> > i'd be lazy (the programmer's mantra? ;) and not bother with any such 
API
> > until it is shown to be necessary. i would not be surprised if every user
> > of KActivities::Info ends up being some QML code somewhere.
> 
> do you want to be proofed wrong? ;-) kwin/useractions.cpp line 691 following
> (frameworks-scratch branch)

filling a popup menu hardly seems a good reason to have a whole class in a 
library.

visiting lxr.kde.org, it turns out that there are 4 use cases:

* filling a QMenu (kwin, tasks plasmoid)
* filling a combobox
* populating a dataengine (SLC, activities)
* searching in an AbstractRunner

the last three either can use a model or will be moving to models in Plasma 2. 
which means the only use case right now is populating a popup menu. in 2 
places.

-- 
Aaron J. Seigo
["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]