[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly
From: "Paul Rohrbach" <p.b.r () gmx ! net>
Date: 2013-09-11 18:03:57
Message-ID: 20130911180357.8625.75214 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 11, 2013, 5:59 p.m., Sebastian Kügler wrote:
> > Looks good, thanks! Please commit this patch to KDE/4.11, master and \
> > frameworks-scratch branches.
Thank you for accepting the patch :). But I can't commit it, because I don't have \
commit rights.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112674/#review39848
-----------------------------------------------------------
On Sept. 11, 2013, 5:48 p.m., Paul Rohrbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112674/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2013, 5:48 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patch should solve bug 313869.
>
> The bug reported this behaviour: if you press something like 'a+b+c=', the result \
> would be incorrect because the calculator plasmoid wrongly resets the calculator \
> when pressing 'c'. The intended behaviour is that the calculation is cleared when \
> pressing a number after pressing '='.
> This patch adds a variable to determine this situation correctly.
>
>
> This addresses bug 313869.
> http://bugs.kde.org/show_bug.cgi?id=313869
>
>
> Diffs
> -----
>
> applets/calculator/package/contents/ui/calculator.qml b4f0654
>
> Diff: http://git.reviewboard.kde.org/r/112674/diff/
>
>
> Testing
> -------
>
> It works for me in Plasmate.
>
>
> Thanks,
>
> Paul Rohrbach
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112674/">http://git.reviewboard.kde.org/r/112674/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 11th, 2013, 5:59 p.m. UTC, \
<b>Sebastian Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Looks good, thanks! Please commit this patch to \
KDE/4.11, master and frameworks-scratch branches.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you for accepting \
the patch :). But I can't commit it, because I don't have commit \
rights.</pre> <br />
<p>- Paul</p>
<br />
<p>On September 11th, 2013, 5:48 p.m. UTC, Paul Rohrbach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Paul Rohrbach.</div>
<p style="color: grey;"><i>Updated Sept. 11, 2013, 5:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch should solve bug 313869.
The bug reported this behaviour: if you press something like 'a+b+c=', the \
result would be incorrect because the calculator plasmoid wrongly resets the \
calculator when pressing 'c'. The intended behaviour is that the calculation \
is cleared when pressing a number after pressing '='.
This patch adds a variable to determine this situation correctly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works for me in Plasmate.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=313869">313869</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/calculator/package/contents/ui/calculator.qml <span style="color: \
grey">(b4f0654)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112674/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic