'Re: Review Request 111770: Implemented search feature in Local Browsing.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 111770: Implemented search feature in Local Browsing.
From:       "Sinny Kumari" <ksinny () gmail ! com>
Date:       2013-09-11 7:37:52
Message-ID: 20130911073752.21116.63153 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Sept. 11, 2013, 7:31 a.m., Sinny Kumari wrote:
> > One issue
> > Suppose I searched for videos folder in search bar. Now, with search filter i can \
> > see videos folder in mediabrowser. Later when I click on video folder to broswe \
> > inside then it shows me blank. This is happening becasue still it is trying to \
> > search with name video. This should not happen, search should be called only for \
> > current browsing page where user typed it

Snapshots:
http://wstaw.org/m/2013/09/11/snapshot1.png (when searched for videos)
http://wstaw.org/m/2013/09/11/snapshot2.png (when clicked on filterd search i.e on \
videos)

- Sinny

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111770/#review39798
-----------------------------------------------------------

On Sept. 10, 2013, 7:31 p.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111770/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2013, 7:31 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Description
> -------
> 
> Plasma Media Center now supports searching in local files and media. Used Regular \
> expression to match the name. 
> Request to merge the branch akshay_localSearch to master of PMC.
> 
> 
> Diffs
> -----
> 
> browsingbackends/localfiles/localfilesabstractbackend.h 84758e4 
> browsingbackends/localfiles/localfilesabstractbackend.cpp 1144e49 
> browsingbackends/localfiles/localfilesabstractmodel.h 43f50b7 
> browsingbackends/localfiles/localfilesabstractmodel.cpp ebfc602 
> mediaelements/mediabrowser/MediaBrowser.qml 6ae777f 
> 
> Diff: http://git.reviewboard.kde.org/r/111770/diff/
> 
> 
> Testing
> -------
> 
> Works as intended.
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111770/">http://git.reviewboard.kde.org/r/111770/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On September 11th, 2013, 7:31 a.m. UTC, <b>Sinny \
Kumari</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">One issue Suppose I searched for videos folder in search bar. Now, with \
search filter i can see videos folder in mediabrowser. Later when I click on video \
folder to broswe inside then it shows me blank. This is happening becasue still it is \
trying to search with name video. This should not happen, search should be called \
only for current browsing page where user typed it</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Snapshots: \
http://wstaw.org/m/2013/09/11/snapshot1.png (when searched for videos) \
http://wstaw.org/m/2013/09/11/snapshot2.png (when clicked on filterd search i.e on \
videos) </pre>
<br />

<p>- Sinny</p>

<br />
<p>On September 10th, 2013, 7:31 p.m. UTC, Akshay Ratan wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.</div> <div>By Akshay Ratan.</div>

<p style="color: grey;"><i>Updated Sept. 10, 2013, 7:31 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Plasma Media Center now supports searching in local files and media. \
Used Regular expression to match the name.

Request to merge the branch akshay_localSearch to master of PMC.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works as intended.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>browsingbackends/localfiles/localfilesabstractbackend.h <span style="color: \
grey">(84758e4)</span></li>

 <li>browsingbackends/localfiles/localfilesabstractbackend.cpp <span style="color: \
grey">(1144e49)</span></li>

 <li>browsingbackends/localfiles/localfilesabstractmodel.h <span style="color: \
grey">(43f50b7)</span></li>

 <li>browsingbackends/localfiles/localfilesabstractmodel.cpp <span style="color: \
grey">(ebfc602)</span></li>

 <li>mediaelements/mediabrowser/MediaBrowser.qml <span style="color: \
grey">(6ae777f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111770/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 