'Re: Review Request 112445: Port EffectWatcher to XCB'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 112445: Port EffectWatcher to XCB
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2013-09-11 0:00:28
Message-ID: 20130911000028.3953.593 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112445/#review39791
-----------------------------------------------------------

What happened to this? It seems to make sense...

- Aleix Pol Gonzalez

On Sept. 2, 2013, 8:10 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112445/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2013, 8:10 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Saves quite a lot of roundtrips to the XServer. Most important we
> fetch the atom only once which means we don't have to refetch when
> checking the property notify events.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 84a79114bedc40d315fd110bb176855b0c0db76a 
>   src/declarativeimports/core/CMakeLists.txt 12c06901b51cd85f2a5e47599bf7a579e8d4d476 
>   src/plasma/CMakeLists.txt 1392309c4b6f433a01b1d87f9784037738bb73b3 
>   src/plasma/private/effectwatcher.cpp 58ca9425ed4ef283f629a6d0c0567435b5db565d 
>   src/plasma/private/effectwatcher_p.h 626b1e6eb9e5209a0633ffdcdb3d186c74c99ecc 
> 
> Diff: http://git.reviewboard.kde.org/r/112445/diff/
> 
> 
> Testing
> -------
> 
> It compiles. There's no unit test for it, so I cannot really test
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112445/">http://git.reviewboard.kde.org/r/112445/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What happened to this? \
It seems to make sense...</pre>  <br />

<p>- Aleix</p>

<br />
<p>On September 2nd, 2013, 8:10 a.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Sept. 2, 2013, 8:10 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Saves quite a lot of roundtrips to the XServer. Most important we fetch \
the atom only once which means we don&#39;t have to refetch when checking the \
property notify events.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It compiles. There&#39;s no unit test for it, so I cannot really \
test</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(84a79114bedc40d315fd110bb176855b0c0db76a)</span></li>

 <li>src/declarativeimports/core/CMakeLists.txt <span style="color: \
grey">(12c06901b51cd85f2a5e47599bf7a579e8d4d476)</span></li>

 <li>src/plasma/CMakeLists.txt <span style="color: \
grey">(1392309c4b6f433a01b1d87f9784037738bb73b3)</span></li>

 <li>src/plasma/private/effectwatcher.cpp <span style="color: \
grey">(58ca9425ed4ef283f629a6d0c0567435b5db565d)</span></li>

 <li>src/plasma/private/effectwatcher_p.h <span style="color: \
grey">(626b1e6eb9e5209a0633ffdcdb3d186c74c99ecc)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112445/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 