'Re: Review Request 112499: Rework finding of XCB'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 112499: Rework finding of XCB
From:       "Commit Hook" <null () kde ! org>
Date:       2013-09-09 4:15:18
Message-ID: 20130909041518.8242.33823 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112499/
-----------------------------------------------------------

(Updated Sept. 9, 2013, 4:15 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.

Description
-------

Rework finding of XCB

Uses the new components syntax of FindXCB. So far plasma frameworks
only need the XCB component and that one is optional just like XLib.

The find xcb is moved to the toplevel CMakeLists.txt together with
the find x11 and HAVE_X11 gets set only if both X11 and XCB are found.

Note: requires https://git.reviewboard.kde.org/r/112151/ in ECM

Diffs
-----

  CMakeLists.txt 84a79114bedc40d315fd110bb176855b0c0db76a 
  src/declarativeimports/core/CMakeLists.txt 12c06901b51cd85f2a5e47599bf7a579e8d4d476 
  src/shell/CMakeLists.txt 5e2fec4b2f0b06f7f6fee3963f730a34f5d03836 

Diff: http://git.reviewboard.kde.org/r/112499/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112499/">http://git.reviewboard.kde.org/r/112499/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Sept. 9, 2013, 4:15 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rework finding of XCB

Uses the new components syntax of FindXCB. So far plasma frameworks
only need the XCB component and that one is optional just like XLib.

The find xcb is moved to the toplevel CMakeLists.txt together with
the find x11 and HAVE_X11 gets set only if both X11 and XCB are found.

Note: requires https://git.reviewboard.kde.org/r/112151/ in ECM</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(84a79114bedc40d315fd110bb176855b0c0db76a)</span></li>

 <li>src/declarativeimports/core/CMakeLists.txt <span style="color: \
grey">(12c06901b51cd85f2a5e47599bf7a579e8d4d476)</span></li>

 <li>src/shell/CMakeLists.txt <span style="color: \
grey">(5e2fec4b2f0b06f7f6fee3963f730a34f5d03836)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112499/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 