'Re: Review Request 112502: Roughly port devicenotifier to plasma2'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 112502: Roughly port devicenotifier to plasma2
From:       "Commit Hook" <null () kde ! org>
Date:       2013-09-04 14:34:42
Message-ID: 20130904143442.10153.3858 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112502/
-----------------------------------------------------------

(Updated Sept. 4, 2013, 2:34 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Sebastian Kügler.

Description
-------

Changed imports
Install package in CMakeLists.txt
Removed Plasma.Theme
Adjusted namespace where necessary
other changes

Diffs
-----

  plasma/generic/applets/CMakeLists.txt a84c1dc 
  plasma/generic/applets/devicenotifier/CMakeLists.txt 8d70303 
  plasma/generic/applets/devicenotifier/package/contents/ui/ActionItem.qml 1394d57 
  plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml f6e57e9 
  plasma/generic/applets/devicenotifier/package/contents/ui/StatusBar.qml 11e67d4 
  plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml 9b6132e 
  plasma/generic/applets/devicenotifier/package/metadata.desktop 6d24cc4 

Diff: http://git.reviewboard.kde.org/r/112502/diff/

Testing
-------

compiles - nothing needs to compile.
installs - check
works - somewhat, shows attached device, installed test action.

However there are many glitches..

Thanks,

Bhushan Shah

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112502/">http://git.reviewboard.kde.org/r/112502/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Bhushan Shah.</div>

<p style="color: grey;"><i>Updated Sept. 4, 2013, 2:34 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changed imports Install package in CMakeLists.txt
Removed Plasma.Theme
Adjusted namespace where necessary
other changes</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles - nothing needs to compile. installs - check
works - somewhat, shows attached device, installed test action.

However there are many glitches..</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/CMakeLists.txt <span style="color: \
grey">(a84c1dc)</span></li>

 <li>plasma/generic/applets/devicenotifier/CMakeLists.txt <span style="color: \
grey">(8d70303)</span></li>

 <li>plasma/generic/applets/devicenotifier/package/contents/ui/ActionItem.qml <span \
style="color: grey">(1394d57)</span></li>

 <li>plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml <span \
style="color: grey">(f6e57e9)</span></li>

 <li>plasma/generic/applets/devicenotifier/package/contents/ui/StatusBar.qml <span \
style="color: grey">(11e67d4)</span></li>

 <li>plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml \
<span style="color: grey">(9b6132e)</span></li>

 <li>plasma/generic/applets/devicenotifier/package/metadata.desktop <span \
style="color: grey">(6d24cc4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112502/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 