[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112329: Oxygen Style: Check widget validity in group box drawing
From: "Hugo Pereira Da Costa" <hugo () oxygen-icons ! org>
Date: 2013-08-28 20:46:13
Message-ID: 20130828204613.12654.28552 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112329/#review38810
-----------------------------------------------------------
Ship it!
Ship It!
- Hugo Pereira Da Costa
On Aug. 28, 2013, 5:24 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112329/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 5:24 p.m.)
>
>
> Review request for Plasma and Hugo Pereira Da Costa.
>
>
> Description
> -------
>
> Check widget validity in group box drawing
>
> Widget is an optional parameter and may be 0.
> This currently causes a crash when GroupBox is used by QtQuickControls
>
> --
>
> Not sure which group to set, please reassign if plasma is wrong.
>
>
> Diffs
> -----
>
> kstyles/oxygen/oxygenstyle.cpp 801bf2195edf8114c5f0ea9b9d1235711bc5728a
>
> Diff: http://git.reviewboard.kde.org/r/112329/diff/
>
>
> Testing
> -------
>
> Created QML test app to recreate some of OxygenDemo
> No longer crashes \o/
>
>
> Thanks,
>
> David Edmundson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112329/">http://git.reviewboard.kde.org/r/112329/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Hugo</p>
<br />
<p>On August 28th, 2013, 5:24 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Hugo Pereira Da Costa.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2013, 5:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Check widget validity in group box drawing
Widget is an optional parameter and may be 0.
This currently causes a crash when GroupBox is used by QtQuickControls
--
Not sure which group to set, please reassign if plasma is wrong.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Created QML test app to recreate some of OxygenDemo No longer crashes \
\o/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstyles/oxygen/oxygenstyle.cpp <span style="color: \
grey">(801bf2195edf8114c5f0ea9b9d1235711bc5728a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112329/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic