Review request for kde-workspace, Plasma and Eike Hein.
By Bhushan Shah.
Updated Aug. 25, 2013, 2:44 p.m.
Description
Fix the crash in plasma-desktop caused by newer QML taskbar widget.
Simple steps to reproduce this crash.
1) Pin any task/application to taskbar using "show launcher when not running" option.
2) Close application.
3) Desktop crashes.
Reason :
1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions,
-> pointer to task is not null
-> taskItem itself is not null
-> scene is not null
2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed.
Patch :
This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item.
|
Testing
Testing
compilation - check
installation - check
plasmoidviewer - check
in panel - check
independently - check
|
Diffs
- plasma/desktop/applets/tasks/tasks.cpp (c4aef4b)
View Diff
|