From kde-panel-devel Sun Aug 25 14:44:11 2013 From: "Eike Hein" Date: Sun, 25 Aug 2013 14:44:11 +0000 To: kde-panel-devel Subject: Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget Message-Id: <20130825144411.22195.27426 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=137744188716041 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2456916876830988094==" --===============2456916876830988094== Content-Type: multipart/alternative; boundary="===============3258042263614528431==" --===============3258042263614528431== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/ ----------------------------------------------------------- (Updated Aug. 25, 2013, 2:44 p.m.) Status ------ This change has been discarded. Review request for kde-workspace, Plasma and Eike Hein. Description ------- Fix the crash in plasma-desktop caused by newer QML taskbar widget. Simple steps to reproduce this crash. 1) Pin any task/application to taskbar using "show launcher when not running" option. 2) Close application. 3) Desktop crashes. Reason : 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, -> pointer to task is not null -> taskItem itself is not null -> scene is not null 2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed. Patch : This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item. Diffs ----- plasma/desktop/applets/tasks/tasks.cpp c4aef4b Diff: http://git.reviewboard.kde.org/r/112241/diff/ Testing ------- Testing compilation - check installation - check plasmoidviewer - check in panel - check independently - check Thanks, Bhushan Shah --===============3258042263614528431== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/

This change has been discarded.

Review request for kde-workspace, Plasma and Eike Hein.
By Bhushan Shah.

Updated Aug. 25, 2013, 2:44 p.m.

Description 

Fix the crash in plasma-desktop caused by newer QML taskbar widget.

Simple steps to reproduce this crash.

1) Pin any task/application to taskbar using "show launcher when not running" option.
2) Close application.
3) Desktop crashes.

Reason :

1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three conditions, 

  -> pointer to task is not null
  -> taskItem itself is not null
  -> scene is not null

2) This condition gets false when item is LauncherItem. In function later line 334 when calling iconRect.moveTopLeft(QPoint) function it gets crashed.

Patch :

This patch adds check in if condition to check if taskItem is TaskManager::LauncherItemType and return from function if this is launcher item.

Testing 

Testing

compilation - check
installation - check
plasmoidviewer - check
in panel - check
independently - check

Diffs

  • plasma/desktop/applets/tasks/tasks.cpp (c4aef4b)

View Diff
--===============3258042263614528431==-- --===============2456916876830988094== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2456916876830988094==--